New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxmemory_policy in info memory stanza is incorrect #3187

Closed
therealbill opened this Issue Apr 22, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@therealbill
Contributor

therealbill commented Apr 22, 2016

Currently it is always returning volatile-lru regardless of the actual setting.

This is due to the 'maxmemoryToString' function using the server.maxmemory value rather than the server.maxmemory_policy value.

PR incoming to fix it, just wanted an issue number to reference for completeness.

therealbill added a commit to therealbill/redis that referenced this issue Apr 22, 2016

fix for antirez#3187
I've renamed maxmemoryToString to evictPolicyToString since that is
more accurate (and easier to mentally connect with the correct data), as
well as updated the function to user server.maxmemory_policy rather than
server.maxmemory. Now with a default config it is actually returning
the correct policy rather than volatile-lru.

@antirez antirez closed this in #3188 May 5, 2016

antirez added a commit that referenced this issue May 5, 2016

antirez added a commit that referenced this issue May 5, 2016

fix for #3187
I've renamed maxmemoryToString to evictPolicyToString since that is
more accurate (and easier to mentally connect with the correct data), as
well as updated the function to user server.maxmemory_policy rather than
server.maxmemory. Now with a default config it is actually returning
the correct policy rather than volatile-lru.

JackieXie168 pushed a commit to JackieXie168/redis that referenced this issue Aug 29, 2016

fix for antirez#3187
I've renamed maxmemoryToString to evictPolicyToString since that is
more accurate (and easier to mentally connect with the correct data), as
well as updated the function to user server.maxmemory_policy rather than
server.maxmemory. Now with a default config it is actually returning
the correct policy rather than volatile-lru.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment