Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"make install" should replace binary without requiring server shutdown #335

Closed
ScottKevill opened this issue Feb 14, 2012 · 2 comments
Closed

Comments

@ScottKevill
Copy link

In src/Makefile, change:

INSTALL= cp -p

to:

INSTALL= cp -pf

Updates would be a lot easier if they could be done without downtime. Then the server only has to be restarted for the new update to take effect. This is especially useful if you already have supervisor/manager processes that auto-restart a redis server.

Without it, you get:

cp -p redis-server /usr/local/bin
cp: cannot create regular file `/usr/local/bin/redis-server': Text file busy
make[1]: *** [install] Error 1
make[1]: Leaving directory `xxxxx/redis-2.4.7/src'
make: *** [install] Error 2
antirez added a commit that referenced this issue Feb 14, 2012
needed when installing a new Redis version. Thanks to Scott Kevill.
Fixes issue #335.
antirez added a commit that referenced this issue Feb 14, 2012
needed when installing a new Redis version. Thanks to Scott Kevill.
Fixes issue #335.
@antirez
Copy link
Contributor

antirez commented Feb 14, 2012

Thanks, fixed into unstable and 2.4 branch.

@antirez antirez closed this as completed Feb 14, 2012
@ScottKevill
Copy link
Author

Excellent. Thanks for the quick response.

JackieXie168 pushed a commit to JackieXie168/redis that referenced this issue Aug 29, 2016
needed when installing a new Redis version. Thanks to Scott Kevill.
Fixes issue redis#335.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants