Compilation error on OS X, caused by bundled hiredis #338

Closed
hmarr opened this Issue Feb 17, 2012 · 9 comments

5 participants

@hmarr

I'm getting a problem when trying to install redis with homebrew. I'm using OS X 10.7.3 and XCode 4.3 (gcc 4.2.1). The error occurs when compiling hiredis (bundled in deps). The output is here: https://gist.github.com/1852852

This is the same problem described here: https://github.com/antirez/hiredis/issues/53

I've fix referenced in the above hiredis issue (antirez/hiredis@5def864...2da784c) does fix the issue, but is not included in the hiredis that's bundled in deps. Updating the bundled hiredis version should resolve this.

@hmarr

Managed to install by passing --use-llvm to homebrew. Seems like it's just clang that doesn't work. Not sure what the stance is on supporting clang, so closing for now.

@hmarr hmarr closed this Feb 17, 2012
@jacknagel

Anecdotally, I believe this is currently the only thing blocking all of redis from compiling with clang 3.x.

@Sharpie

This should get re-opened until the fixes are pulled into the main repo. The Homebrew issue tracker has already received two reports since Xcode 4.3 came out: Homebrew/legacy-homebrew#10299 and Homebrew/legacy-homebrew#10305. The issue has also been mentioned in a few other reports.

@hmarr hmarr reopened this Feb 18, 2012
@antirez
Owner

Hello, I updated Redis unstable with the latest hiredis, please could you verify that now it builds without problems? I'm trying to verify but there is a 2GB download between me and the ability to try this... ;) Thanks.

@hmarr

Works great for me - thanks Salvatore!

@hmarr hmarr closed this Feb 19, 2012
@Sharpie

I'm trying to verify but there is a 2GB download between me and the ability to try this... ;)

@antirez

For Xcode 4.3, the command line tools, compilers and custom headers are available as a separate download that clocks in at ~163 MB available from http://connect.apple.com as "Command Line Tools for Xcode"

Mad props to Kenneth Reitz for making this happen:

http://www.kennethreitz.com/xcode-gcc-and-homebrew.html

@mxcl

See 1e62ec70326af16be5feacc257f176f6beaf5a5e. I felt Redis was important enough to commit a workaround for now.

@antirez
Owner

I think this should be fixed now, both on 2.4 and unstable branch. Could you confirm please? Thank you.

@antirez
Owner

p.s. there is a failing test in 2.4 when compiling with clang, I'll fix it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment