test failure in 2.4.8 #350

Closed
tombouctou opened this Issue Feb 22, 2012 · 7 comments

Comments

Projects
None yet
4 participants
@tombouctou

I don't know if this is an issue or not, but redis 2.4.8 fails one test:
*** [err]: Protocol desync regression test #2 in tests/unit/protocol.tcl
uname -a 1:26 12-02-23
Linux 3.0.0-12-server #20-Ubuntu SMP Fri Oct 7 16:36:30 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux

@tombouctou

This comment has been minimized.

Show comment Hide comment
@tombouctou

tombouctou Feb 22, 2012

otoh, unstable tests are fine on the same machine

otoh, unstable tests are fine on the same machine

@antirez

This comment has been minimized.

Show comment Hide comment
@antirez

antirez Feb 26, 2012

Owner

@vissi Hi, this is almost surely not a real issue, but better to investigate better: it fails every time you run the script? What is the full error given (if there is a failing assert or alike)? Thanks.

Owner

antirez commented Feb 26, 2012

@vissi Hi, this is almost surely not a real issue, but better to investigate better: it fails every time you run the script? What is the full error given (if there is a failing assert or alike)? Thanks.

@tombouctou

This comment has been minimized.

Show comment Hide comment
@tombouctou

tombouctou Feb 26, 2012

Yes, the second run was ok.

Yes, the second run was ok.

@antirez

This comment has been minimized.

Show comment Hide comment
@antirez

antirez Feb 26, 2012

Owner

Thank you, I put in my TODO list that I should make this test more resistent to false positives.
Closing.

Owner

antirez commented Feb 26, 2012

Thank you, I put in my TODO list that I should make this test more resistent to false positives.
Closing.

@antirez antirez closed this Feb 26, 2012

@RajivKurian

This comment has been minimized.

Show comment Hide comment
@RajivKurian

RajivKurian Mar 14, 2012

Any reason this is happening ? The tests run successfully sometimes and fail some other times.

Any reason this is happening ? The tests run successfully sometimes and fail some other times.

@antirez

This comment has been minimized.

Show comment Hide comment
@antirez

antirez Mar 14, 2012

Owner

It's just a timing issue basically. It's the test that does not work well, not Redis :) But it's worth fixing indeed. Only happens in slow systems probably. Reopening so that I'll fix it in the next days.

Owner

antirez commented Mar 14, 2012

It's just a timing issue basically. It's the test that does not work well, not Redis :) But it's worth fixing indeed. Only happens in slow systems probably. Reopening so that I'll fix it in the next days.

@antirez antirez reopened this Mar 14, 2012

@RajivKurian

This comment has been minimized.

Show comment Hide comment
@RajivKurian

RajivKurian Mar 14, 2012

thanks @antirez

thanks @antirez

@mattsta mattsta closed this May 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment