Really silly failure with 'make install' #495

Closed
eblume opened this Issue May 4, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@eblume

eblume commented May 4, 2012

I was building redis for the first time today and noticed that 'make install' was giving the following message:

➜  redis-2.6.0-rc2  sudo make install
Password:
make: `install' is up to date.

And yet, redis was most definitely not installed.

I fixed the issue by deleting the 'INSTALL' file, which simply contains some prose instructing the reader to look at README. I have never seen this issue with other builds on my system, so I'm stumped as to why actually it was happening - I thought I knew 'enough' of GNU Make already but I guess not! However I think this might, maybe, just possibly be a bug with Redis under certain OSes and/or make versions. Apologies if it is not.

Here is the output of make -version:

➜  redis-2.6.0-rc2  make -version
GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for i386-apple-darwin11.3.0

I am running OS X 10.7.3, with whatever the most recent version of XCode command-line utilities is (I can never keep track).

@pietern

This comment has been minimized.

Show comment
Hide comment
@pietern

pietern May 4, 2012

Contributor

Thanks! This is indeed pretty silly, but luckily only happens on OSX. It is the only (widely used) OS that I know of which has a case-insensitive file system. We'll need to declare the install target in the root Makefile as being a phony target, similar to other phony targets in our code base.

Contributor

pietern commented May 4, 2012

Thanks! This is indeed pretty silly, but luckily only happens on OSX. It is the only (widely used) OS that I know of which has a case-insensitive file system. We'll need to declare the install target in the root Makefile as being a phony target, similar to other phony targets in our code base.

@eblume

This comment has been minimized.

Show comment
Hide comment
@eblume

eblume May 4, 2012

No problem. I'm normally quite happy with OSX but I have to say this has me very concerned and embarrassed for my platform of choice.

Anyway, thanks for the insight!

eblume commented May 4, 2012

No problem. I'm normally quite happy with OSX but I have to say this has me very concerned and embarrassed for my platform of choice.

Anyway, thanks for the insight!

@pietern pietern closed this May 4, 2012

pietern added a commit that referenced this issue May 15, 2012

antirez added a commit that referenced this issue May 15, 2012

Merge pull request #496 from pietern/2.6-makeinstall
Fix `install` target on OSX (see #495)

tsee added a commit to tsee/redis that referenced this issue Jul 31, 2012

@riywo riywo referenced this issue in matsumotory/ngx_mruby Aug 1, 2013

Merged

Fix `install` target on OSX #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment