New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer overflow hits from Fortify scan of Redis 3.2.12 #5762

Open
tiwatso opened this Issue Jan 9, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@tiwatso
Copy link

tiwatso commented Jan 9, 2019

Hi, we have an organization requirement to run Fortify against all the code of our service including 3rd party software (our service uses Redis 3.2.12).

Fortify reports a number of issues mainly around Buffer overflow, many of them i'm able to resolve as false positives but there is a remaining list that gets pretty deep in the Redis code where i'm not able to easily identify if a real issue or not.

Here is a list;

  1. Buffer Overflow /src/dict.c : 268 SCA High
  2. Buffer Overflow /src/dict.c : 273 SCA High
  3. Buffer Overflow /src/dict.c : 366 SCA High
  4. Buffer Overflow /deps/lua/src/ lstring.c : 62 SCA Critical
  5. Buffer Overflow /src/lzf_c.c : 236 SCA High
  6. Buffer Overflow /src/lzf_c.c : 236 SCA High
  7. Buffer Overflow /src/lzf_c.c : 236 SCA High
  8. Buffer Overflow /src/lzf_c.c : 241 SCA High
  9. Buffer Overflow /src/lzf_c.c : 241 SCA High
  10. Buffer Overflow /src/lzf_c.c : 241 SCA High
  11. Buffer Overflow /src/lzf_c.c : 266 SCA High
  12. Buffer Overflow /src/lzf_c.c : 281 SCA High
  13. Buffer Overflow /src/lzf_d.c : 153 SCA Critical
  14. Buffer Overflow /deps/jemalloc/src/prof.c : 1414 SCA Critical
  15. Buffer Overflow /src/sds.c : 263 SCA Critical
  16. Buffer Overflow /src/t_zset.c : 646 SCA Critical
  17. Buffer Overflow /src/t_zset.c : 647 SCA High
  18. Buffer Overflow /src/ziplist.c : 440 SCA High
  19. Buffer Overflow /src/ziplist.c : 503 SCA Critical
  20. Buffer Overflow /src/ziplist.c : 639 SCA Critical

Could a Redis developer take a look and identify if these are false or real issues (and if real a way to mitigate them)?
Thanks.

@tiwatso

This comment has been minimized.

Copy link

tiwatso commented Jan 10, 2019

If helpful i could provide the fortify trace analysis for the above issues. For instance here is one for dict.c (line 268);

screen shot 2019-01-10 at 1 53 59 pm

screen shot 2019-01-10 at 1 54 13 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment