SLOWLOG is useless with MULTI/EXEC #759

Closed
antirez opened this Issue Nov 9, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@antirez
Owner

antirez commented Nov 9, 2012

as EXEC is logged... without any list of commands. Make it smarter.

@yeago

This comment has been minimized.

Show comment Hide comment
@yeago

yeago Jan 17, 2013

yeah, do it

yeago commented Jan 17, 2013

yeah, do it

antirez added a commit that referenced this issue Jan 19, 2013

Slowlog: don't log EXEC but just the executed commands.
The Redis Slow Log always used to log the slow commands executed inside
a MULTI/EXEC block. However also EXEC was logged at the end, which is
perfectly useless.

Now EXEC is no longer logged and a test was added to test this behavior.

This fixes issue #759.

antirez added a commit that referenced this issue Jan 19, 2013

Slowlog: don't log EXEC but just the executed commands.
The Redis Slow Log always used to log the slow commands executed inside
a MULTI/EXEC block. However also EXEC was logged at the end, which is
perfectly useless.

Now EXEC is no longer logged and a test was added to test this behavior.

This fixes issue #759.

antirez added a commit that referenced this issue Jan 19, 2013

Slowlog: don't log EXEC but just the executed commands.
The Redis Slow Log always used to log the slow commands executed inside
a MULTI/EXEC block. However also EXEC was logged at the end, which is
perfectly useless.

Now EXEC is no longer logged and a test was added to test this behavior.

This fixes issue #759.
@antirez

This comment has been minimized.

Show comment Hide comment
@antirez

antirez Jan 19, 2013

Owner

Actually the problem was a lot less sever, EXEC was also logged, but together with the executed commands. Anyway now EXEC is no longer logged and the issue can be closed.

Owner

antirez commented Jan 19, 2013

Actually the problem was a lot less sever, EXEC was also logged, but together with the executed commands. Anyway now EXEC is no longer logged and the issue can be closed.

@antirez antirez closed this Jan 19, 2013

JackieXie168 pushed a commit to JackieXie168/redis that referenced this issue Aug 29, 2016

Slowlog: don't log EXEC but just the executed commands.
The Redis Slow Log always used to log the slow commands executed inside
a MULTI/EXEC block. However also EXEC was logged at the end, which is
perfectly useless.

Now EXEC is no longer logged and a test was added to test this behavior.

This fixes issue #759.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment