Crash on redis benchmark #782

Closed
dvirsky opened this Issue Nov 21, 2012 · 3 comments

3 participants

@dvirsky

on redis 2.5.14 (haven't tried with stable), running with -P and -r causes an assertion fail and crash:

$ redis-benchmark -t set -p 6379 -n 1000000 -c 100 -r 1000 -P 1000
redis-benchmark: redis-benchmark.c:280: createClient: Assertion `c->randlen < (signed)(sizeof(c->randptr)/sizeof(char*))' failed.
Aborted (core dumped)

$ redis-benchmark -t get -p 6379 -n 1000000 -c 100 -r 1000 -P 1000
redis-benchmark: redis-benchmark.c:280: createClient: Assertion `c->randlen < (signed)(sizeof(c->randptr)/sizeof(char*))' failed.
Aborted (core dumped)
@antirez
Owner

This is an hardcoded limit inside the code, the assert is used in order to avoid a random crash, at least the assertion is more readable :-)

Thanks for signaling it, I'll keep this open to fix it at least before 2.8.

Cheers

@dvirsky

well, at least it's not a RAM corruption ;) I figured as much. It would still be nice to have this capability.

@mattsta

Fixed by 346256f

@mattsta mattsta closed this Aug 14, 2014
@JackieXie168 JackieXie168 pushed a commit that referenced this issue Sep 16, 2014
@timmaxw timmaxw Limit 4 metablocks per extent
This speeds up database creation immensely. It also fixes #782 because it makes
the window in which a crash would have to happen so small that it can be safely
ignored.
56dd541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment