Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Crash on redis benchmark #782

Closed
dvirsky opened this Issue · 3 comments

3 participants

Dvir Volk Salvatore Sanfilippo Matt Stancliff
Dvir Volk

on redis 2.5.14 (haven't tried with stable), running with -P and -r causes an assertion fail and crash:

$ redis-benchmark -t set -p 6379 -n 1000000 -c 100 -r 1000 -P 1000
redis-benchmark: redis-benchmark.c:280: createClient: Assertion `c->randlen < (signed)(sizeof(c->randptr)/sizeof(char*))' failed.
Aborted (core dumped)

$ redis-benchmark -t get -p 6379 -n 1000000 -c 100 -r 1000 -P 1000
redis-benchmark: redis-benchmark.c:280: createClient: Assertion `c->randlen < (signed)(sizeof(c->randptr)/sizeof(char*))' failed.
Aborted (core dumped)
Salvatore Sanfilippo
Owner

This is an hardcoded limit inside the code, the assert is used in order to avoid a random crash, at least the assertion is more readable :-)

Thanks for signaling it, I'll keep this open to fix it at least before 2.8.

Cheers

Dvir Volk

well, at least it's not a RAM corruption ;) I figured as much. It would still be nice to have this capability.

Matt Stancliff
Collaborator

Fixed by 346256f

Matt Stancliff mattsta closed this
Jackie JackieXie168 referenced this issue from a commit
Timothy Maxwell timmaxw Limit 4 metablocks per extent
This speeds up database creation immensely. It also fixes #782 because it makes
the window in which a crash would have to happen so small that it can be safely
ignored.
56dd541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.