benchmark publish command #1186

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@ybrs

ybrs commented Jul 10, 2013

added publish command to benchmark utility

@emre

This comment has been minimized.

Show comment Hide comment
@emre

emre Jul 19, 2013

👍

emre commented Jul 19, 2013

👍

@moreaki

This comment has been minimized.

Show comment Hide comment
@moreaki

moreaki Aug 20, 2013

Nitpicking, but I'd drop this additional empty line. Otherwise obviously correct patch.

Nitpicking, but I'd drop this additional empty line. Otherwise obviously correct patch.

mattsta added a commit to mattsta/redis that referenced this pull request Aug 2, 2014

mattsta added a commit to mattsta/redis that referenced this pull request Aug 2, 2014

@mattsta mattsta referenced this pull request Aug 2, 2014

Closed

ALL simple issue fixes #1906

mattsta added a commit to mattsta/redis that referenced this pull request Aug 6, 2014

@mattsta

This comment has been minimized.

Show comment Hide comment
@mattsta

mattsta Aug 25, 2014

Contributor

Denied because "testing PUBLISH per-se is like testing PING. Publishing to Pub/Sub channels has a complexity that depends on the number of listeners / patterns. A proper Pub/Sub test simulates how the speed changes while the number of subscribers change. Moreover to do with redis-benchmark what the commit does is as simple as: redis-benchmark PUBLISH foo bar."

Contributor

mattsta commented Aug 25, 2014

Denied because "testing PUBLISH per-se is like testing PING. Publishing to Pub/Sub channels has a complexity that depends on the number of listeners / patterns. A proper Pub/Sub test simulates how the speed changes while the number of subscribers change. Moreover to do with redis-benchmark what the commit does is as simple as: redis-benchmark PUBLISH foo bar."

@mattsta mattsta closed this Aug 25, 2014

@ybrs ybrs deleted the ybrs:benchmark-publish branch Aug 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment