skip rdbLoad when it is slave and waking up #1543

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@charsyam

Because slave will send sync command to Master.
and that time It will load RDB.
so Slave doesn't need to load RDB when it start.

@mattsta mattsta added a commit to mattsta/redis that referenced this pull request Aug 2, 2014
@openbaas openbaas Avoid slave loading RDB on startup
The replica instance will immediately sync with a master anyway,
so we don't need to load anything from disk.

If we add support for PSYNC after instance restart, we will
need different logic here anyway.

Closes #1543
4ae32cd
@mattsta mattsta added a commit to mattsta/redis that referenced this pull request Aug 2, 2014
@openbaas openbaas Avoid slave loading RDB on startup
The replica instance will immediately sync with a master anyway,
so we don't need to load anything from disk.

If we add support for PSYNC after instance restart, we will
need different logic here anyway.

Closes #1543
bb8ce05
@mattsta mattsta referenced this pull request Aug 2, 2014
Closed

ALL simple issue fixes #1906

@mattsta mattsta added a commit to mattsta/redis that referenced this pull request Aug 6, 2014
@openbaas openbaas Avoid slave loading RDB on startup
The replica instance will immediately sync with a master anyway,
so we don't need to load anything from disk.

If we add support for PSYNC after instance restart, we will
need different logic here anyway.

Closes #1543
6db7c02
@mattsta

Denied because "It breaks Cluster / Sentinel failovers after a slave restart and the config directive to serve stale data if we can't connect with the master. In general a slave should do everything is its power to serve stuff after a restart. If it will later be able to connect with the master to refresh its view of the data, fine, otherwise what is authoritative is the latest data it was able to obtain."

@mattsta mattsta closed this Aug 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment