Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Improved bigkeys with progress, pipelining and summary #1569
This commit reworks the redis-cli --bigkeys command to provide more
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
This is another improvement of
The use of pipelining has improved the execution time as well:
I ran the code through valgrind on small and large keyspaces with no mention of invalid reads/writes or other nastiness. It does report a possible leak on line 1337, but that's because the redisContext isn't explicitly freed when the process exits.
Given that keys can be deleted or their types can possibly change between the pipelined
Here is an example of summary information you get at the end:
Please let me know if you see anything silly that I'm doing, and I can sort it for you.