fixed prompt in redis cli when connecting to a socket; fixes issue #306 #314

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@tchajed

tchajed commented Jan 25, 2012

No description provided.

@pietern

This comment has been minimized.

Show comment
Hide comment
@pietern

pietern Jan 25, 2012

Contributor

A couple of remarks. This function:

  • does not follow indentation convention.
  • creates an sds which it not free'd.
  • contains an unnecessary comment.

Can you address these issues? Thanks.

Contributor

pietern commented Jan 25, 2012

A couple of remarks. This function:

  • does not follow indentation convention.
  • creates an sds which it not free'd.
  • contains an unnecessary comment.

Can you address these issues? Thanks.

fixed style issues with cliRefreshPrompt and expanded memory for
config.prompt to account for possibly long socket pathnames
@antirez

This comment has been minimized.

Show comment
Hide comment
@antirez

antirez Feb 21, 2012

Owner

The patch still does not seem ok to me, since when the socket is selected no [db_num] is added to the prompt. Thanks.

Owner

antirez commented Feb 21, 2012

The patch still does not seem ok to me, since when the socket is selected no [db_num] is added to the prompt. Thanks.

@tchajed

This comment has been minimized.

Show comment
Hide comment
@tchajed

tchajed Aug 30, 2016

Closing this since it's long since been fixed.

By the way @antirez, this seems to be my first pull request on GitHub - thanks for being so supportive on it!

tchajed commented Aug 30, 2016

Closing this since it's long since been fixed.

By the way @antirez, this seems to be my first pull request on GitHub - thanks for being so supportive on it!

@tchajed tchajed closed this Aug 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment