Persist Makefile flags (2.6) #455

merged 8 commits into from Apr 18, 2012


None yet

2 participants

pietern commented Apr 14, 2012

A common pattern for building and installing Redis is:

$ make 32bit
$ make install PREFIX=/tmp/whatever

This is not possible now, as changes in some flags may trigger a rebuild. The rebuild is triggered because a change in ARCH / CFLAGS / LDFLAGS / etc requires dependencies to be updated.

This change persists the flags, so they remain the same across runs. When any of the flags change, everything will be rebuilt.

The unstable version of this PR is #456.

pietern added some commits Apr 14, 2012
@pietern pietern Rename ADD_*FLAGS -> REDIS_*FLAGS, REDIS_*FLAGS -> FINAL_*FLAGS
This reflects that REDIS_*FLAGS will only be used for compilation of
Redis and not for its dependencies. Similarly, that FINAL_*FLAGS are
composed of other variables and holds the options that are finally
passed to the compiler and linker.
@pietern pietern The lcov target shouldn't clean
This is not needed because every change in compiler/linker flags
triggers a cleanup.
@pietern pietern Ignore gcov/lcov artifacts cb481f4
@pietern pietern Question mark assignment is not needed 95bc195
@pietern pietern First set defaults, then do composition 61e8825
@pietern pietern Remove unused LIBS variable 3126e08
@pietern pietern Don't set flags recursively 8642295
@pietern pietern Persist `make` settings and trigger rebuild if anything changes d0cd262
@antirez antirez merged commit d00f514 into antirez:2.6 Apr 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment