sds: avoid implicit casting #4630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoav-steinberg
added
the
state:to-be-merged
oranagra
approved these changes
Jun 23, 2022
|
@soloestoy can you rebase this so we can see the CI passes? |
madolson
removed
the
state:to-be-merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy to see 4.0.7 released.
Many 32 bit overflows are fixed, but still remains some others just like #4594 and #4519, especially #4594 which can result in redis crash.
This PR fixes some implicit casting in
sds.c, it's not a critical bug, just avoid warning.