fixed install script to rewrite the default config #544

Merged
merged 1 commit into from Oct 5, 2012

Projects

None yet

4 participants

@dvirsky
dvirsky commented Jun 8, 2012

I've fixed the server install script. It now no longer rewrites a template, but rather takes the default config and uses sed to rewrite it with the script's overrides and install this.

This will avoid a situation where changes to the config need to be ported to the template.

PS:
This patch also fixes the syntax error that caused install_server.sh not to run in unix shell but use bash, so I've changed the interpreter back to /bin/sh

dvir volk fixed server install script to rewrite the default configuration file…
… and not a template, and removed the old config template
0ea1a9c
@dvlzmaycry

so you decided to remove template to avoid its rewrite?

@dvirsky
dvirsky commented Jun 10, 2012

I'm rewriting the original config file directly. so any change to the default config file that does not involve the few arguments set by this script, will not need any change in this script.

@dvlzmaycry

awaiting antirez's green light on this pull

@dvirsky
dvirsky commented Jun 10, 2012

me too :) we've discussed this privately and he was okay with it (the concept). in fact he may have even suggested it originally right after I initially wrote the installer, but I didn't find the time to rewrite it until now.

@dvlzmaycry

How did you discuss it?I thought that GitHub disabled messages function

@dvirsky
dvirsky commented Jun 10, 2012

we have the technology! aren't you on the redis-db google group? plus there's an IRC channel if you're not into that. twitter as well. he's a pretty approachable guy :)

@dvlzmaycry

I knew about google group,but IRC?Could you give me channel please?

@dvirsky
dvirsky commented Jun 10, 2012

#redis on freenode. I haven't been there in months but it used to be pretty active last I have.

@dvlzmaycry

Thanks!

@dvirsky
dvirsky commented Jul 10, 2012

@scalp42 this fix does what your fix does, but completely changes the way the install script creates the config file. hope @antirez will include it in the next 2.6 RC

@antirez antirez merged commit a6305f1 into antirez:2.6 Oct 5, 2012
@antirez
Owner
antirez commented Oct 5, 2012

Merged, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment