New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid user permission keyword and invalid reset to user->allowed_commands #5772

Closed
wants to merge 1 commit into
base: unstable
from

Conversation

Projects
None yet
1 participant
@charsyam
Copy link
Contributor

charsyam commented Jan 12, 2019

There are two issues in ACLInit to call ACLSetUser.
1] using allkeys instead of "+@ALL"
-> it is not +@ALL, in code, there is "allkeys", so I changed. but in RCP1, I think it is better to use +#all

2] invalid reset code
-> I think memset needs allowed_commands, not allowed_subcommand. so it can cause crash.

@antirez

@charsyam charsyam closed this Jan 16, 2019

@charsyam

This comment has been minimized.

Copy link
Contributor

charsyam commented Jan 16, 2019

already fixed by antirez's commit
67754ae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment