Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Conform to most projects by honoring DESTDIR. #609

Closed
wants to merge 1 commit into from

5 participants

@pyr

This helps packager on various OSs. This was a previously submitted which had stray commits in them, it is now cleaned up.

@pyr pyr Conform to most projects by honoring DESTDIR.
This helps packager on various OSs
9e21f82
@pietern

Thanks, looks good. Shouldn't the leading / be removed from PREFIX, since it is otherwise added by DESTDIR?

@pyr
@pyr
pyr commented

@pietern any chance of this moving forward ?

@danielbprice

This would be extremely helpful for packagers of redis.

@pyr
pyr commented
@Keruspe

This really should been applied

@pyr

@antirez, @pietern anything more you need in this PR for it to move forward ?

@Keruspe

@pietern As I saw you closed a previous similar bug asking for a resource saying that DESTDIR is a standard, here is what you're looking for: http://www.gnu.org/prep/standards/html_node/DESTDIR.html

@jsternberg

I would have found this useful for redis 2.6 as I need to install to a non-standard location.

Question though, shouldn't DESTDIR default to empty? The pull request looks like it sets DESTDIR to / by default. If DESTDIR is set to / by default, it will have //usr/local instead of /usr/local when DESTDIR is not present. While not incorrect, I don't see why it can't just be empty.

The following also seems to work in the scenario of DESTDIR being set or unset.

DESTDIR?=

It does do something unexpected though. If you specify a relative DESTDIR, it will install to that directory inside of src instead of the base directory.

$ make install DESTDIR=staging
$ find -name staging
./src/staging
@pyr

@jsternberg while I agree with the bits you're mentioning, I would still like to keep the PR untouched and wait for @antirez or @pietern feedback since the concerns they raised have been addressed

@pyr

@antirez any chance you will look at this or should I just close it ?

@pyr
pyr commented

closing this as no-one seems willing to conduct a review, cheers

@pyr pyr closed this
@JackieXie168 JackieXie168 referenced this pull request from a commit
@wmrowan wmrowan Closes issue #609 and #564
Adds fixes for incorrect usage of `recv` and adds handles default case
for unknown response types.

More changes for #609

This shouldn't affect functionality but is nevertheless more correct.

more is to == changes
62008ec
@JackieXie168 JackieXie168 referenced this pull request from a commit
@wmrowan wmrowan Closes issue #609 and #564
Adds fixes for incorrect usage of `recv` and adds handles default case
for unknown response types.

More changes for #609

This shouldn't affect functionality but is nevertheless more correct.

more is to == changes
88ff70b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 30, 2012
  1. @pyr

    Conform to most projects by honoring DESTDIR.

    pyr authored
    This helps packager on various OSs
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 1 deletion.
  1. +2 −1  src/Makefile
View
3  src/Makefile
@@ -80,8 +80,9 @@ REDIS_CC=$(QUIET_CC)$(CC) $(FINAL_CFLAGS)
REDIS_LD=$(QUIET_LINK)$(CC) $(FINAL_LDFLAGS)
REDIS_INSTALL=$(QUIET_INSTALL)$(INSTALL)
+DESTDIR?=/
PREFIX?=/usr/local
-INSTALL_BIN= $(PREFIX)/bin
+INSTALL_BIN= $(DESTDIR)$(PREFIX)/bin
INSTALL= cp -pf
CCCOLOR="\033[34m"
Something went wrong with that request. Please try again.