Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fix to use command name when SETEX/PSETEX fail #811

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

charsyam commented Dec 5, 2012

when using SETEX/PSETEX and when their expire time is less than 0
their error message are the same.

redis 127.0.0.1:6379> SETEX mykey -1 "Hello"
(error) ERR invalid expire time in SETEX
(5.60s)
redis 127.0.0.1:6379> PSETEX mykey -1 "Hello"
(error) ERR invalid expire time in SETEX
(3.69s)

so I changed to use their own names when PSETEX fails

redis 127.0.0.1:6379> SETEX mykey -1 "Hello"
(error) ERR invalid expire time in SETEX
redis 127.0.0.1:6379> PSETEX mykey -1 "Hello"
(error) ERR invalid expire time in PSETEX
redis 127.0.0.1:6379> 

@mattsta mattsta added a commit to mattsta/redis that referenced this pull request Aug 2, 2014

@mattsta mattsta Fix error message of SETEX/PSETEX
This is a rewritten version of #811

Closes #811
ad70df4

@mattsta mattsta added a commit to mattsta/redis that referenced this pull request Aug 2, 2014

@mattsta mattsta Fix error message of SETEX/PSETEX
This is a rewritten version of #811

Closes #811
2a0c018

@mattsta mattsta referenced this pull request Aug 2, 2014

Closed

ALL simple issue fixes #1906

@mattsta mattsta added a commit to mattsta/redis that referenced this pull request Aug 6, 2014

@mattsta mattsta Fix error message of SETEX/PSETEX
This is a rewritten version of #811

Closes #811
cd3905d
Contributor

mattsta commented Aug 25, 2014

Fixed in a6edfce (command name is now lowercase in error message).

@mattsta mattsta closed this Aug 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment