Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

remove compile warning #907

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

charsyam commented Jan 24, 2013

This patch just removes the following build warning messages:

    CC dict.o
    CC redis.o
redis.c: In function ‘genRedisInfoString’:
redis.c:1967:13: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 6 has type ‘uint64_t’ [-Wformat]
redis.c: In function ‘version’:
redis.c:2505:9: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 7 has type ‘uint64_t’ [-Wformat]
    CC sds.o
    CC zmalloc.o

and now

    CC dict.o
    CC redis.o
    CC sds.o
    CC zmalloc.o
Owner

antirez commented Jan 25, 2013

Thank you, makes sense, however we spell it unsigned long long in the whole code base! No need to change it now :-)

Contributor

charsyam commented Jan 25, 2013

@antirez Thank you for your answer

@charsyam charsyam closed this Jan 25, 2013

@charsyam charsyam reopened this Feb 11, 2013

Contributor

charsyam commented Feb 11, 2013

I just think removing warning with casting is better than showing warning.

Owner

antirez commented Feb 12, 2013

I agree, just change the (long long unsigned int) that does not following the Redis coding standard with (unsigned long long) and the patch will be accepted. This was the initial request.

@charsyam charsyam closed this Mar 30, 2013

@charsyam charsyam deleted the charsyam:redis-compile-warning branch Mar 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment