New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Automatic-Module-Name #2223

Merged
merged 2 commits into from Mar 18, 2018

Conversation

Projects
None yet
2 participants
@io7m
Contributor

io7m commented Feb 11, 2018

This adds an Automatic-Module-Name entry to the runtime jar in order to
provide a stable name upon which other modules can depend. The module
name chosen was "org.antlr.antlr4.runtime". This closely matches the
Maven artifact name with the obvious change that the module name
doesn't contain a hyphen (hyphens can't be used in module names at
the language level in Java).

I have signed the contributor agreement in a separate commit below.

Fix #2163

io7m added some commits Feb 11, 2018

Add an Automatic-Module-Name
This adds an Automatic-Module-Name entry to the runtime jar in order to
provide a stable name upon which other modules can depend. The module
name chosen was "org.antlr.antlr4.runtime". This closely matches the
Maven artifact name with the obviously change that the module name
doesn't contain a hyphen (hyphens can't be used in module names at
the language level in Java).

Fix #2163

@io7m io7m referenced this pull request Feb 11, 2018

Open

JDK 9 Modularization #484

9 of 10 tasks complete

io7m added a commit to io7m/jgrapht that referenced this pull request Feb 11, 2018

Write initial experimental module descriptors
This provides module-info.java files for the core and io
modules. These absolutely should *NOT* make it into any release,
because the io descriptor has a "requires" clause that mentions
the automatically-generated "antlr4.runtime" name as opposed to the
correct "org.antlr.antlr4.runtime" name that must be used if and when
the Antlr4 Automatic-Module-Name is published. The old name
is used purely to test whether or not the code works when modularized.

See antlr/antlr4#2223

Affects jgrapht#484
@parrt

This comment has been minimized.

Member

parrt commented Mar 18, 2018

hiya. as we don't support even java 8 yet, is there any chance this will mess up the jar for < java 9?

@parrt parrt added the comp:build label Mar 18, 2018

@io7m

This comment has been minimized.

Contributor

io7m commented Mar 18, 2018

'Ello.

No chance of compatibility problems. It's just a manifest attribute and it's ignored on anything prior to Java 9.

@parrt

This comment has been minimized.

Member

parrt commented Mar 18, 2018

ok, sounds good to me. thanks.

@parrt parrt added this to the 4.7.2 milestone Mar 18, 2018

@parrt parrt merged commit 6ffc59d into antlr:master Mar 18, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@io7m

This comment has been minimized.

Contributor

io7m commented Mar 18, 2018

Thanks!

@io7m

This comment has been minimized.

Contributor

io7m commented May 25, 2018

@parrt Any chance I could nudge you into releasing 4.7.2? I can only see one thing left on the milestones and that already seems to be resolved based on the conversation in the ticket.

@parrt

This comment has been minimized.

Member

parrt commented May 25, 2018

It's an involved process and it's not my focus at the moment. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment