Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swift] Make ParserATNSimulator.precedenceTransition return a nullable value. #2408

Merged
merged 1 commit into from Nov 15, 2018

Conversation

@ewanmellor
Copy link
Contributor

ewanmellor commented Nov 15, 2018

This was always clearly a possibility, looking at the body of the method.
The newly-enabled performance tests expose this bug (and I don't know how
we've gotten away with it otherwise for so long).

The Java runtime also returns null at this point.

This fixes the test failures currently seen in PR #2405 and #2407.

…e value.

This was always clearly a possibility, looking at the body of the method.
The newly-enabled performance tests expose this bug (and I don't know how
we've gotten away with it otherwise for so long).

The Java runtime also returns null at this point.
@parrt parrt added the target:swift label Nov 15, 2018
@parrt parrt added this to the 4.7.2 milestone Nov 15, 2018
@parrt parrt merged commit 9611faa into antlr:master Nov 15, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@ewanmellor ewanmellor deleted the ewanmellor:swift-fix-perf-tests branch May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.