Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s-login version prints constant value #1

Closed
anton-johansson opened this Issue Apr 11, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@anton-johansson
Copy link
Owner

anton-johansson commented Apr 11, 2019

It should print the actual version instead.

@anton-johansson anton-johansson added the bug label Apr 11, 2019

@anton-johansson

This comment has been minimized.

Copy link
Owner Author

anton-johansson commented Apr 11, 2019

See how Kubernetes handles this:
https://github.com/kubernetes/kubernetes/blob/c4fd78e7c9f14c84b122caaa36a937a8868dff2f/pkg/version/base.go

There is no built in tool, so we'll have to bake this information into the artifact when building it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.