Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace go get reflex #3

Closed
anton-johansson opened this issue Aug 9, 2019 · 2 comments

Comments

@anton-johansson
Copy link
Owner

commented Aug 9, 2019

We do this in make dev-go:

$ go get github.com/cespare/reflex

This causes the go.mod file to change, which we do not want. See golang/go#27643. Is there an alternative approach to installing a tool without changing the dependency graph?

@anton-johansson

This comment has been minimized.

Copy link
Owner Author

commented Aug 9, 2019

Same with shurcooL/vfsgen. We use it in the build process to embed static files. It pollutes the go.mod and go.sum too.

@anton-johansson

This comment has been minimized.

Copy link
Owner Author

commented Aug 9, 2019

See golang/go#32504

I tried the tools.go, but for two out of three tools I use I get the following message:

cmd/kertificate/tools.go:7:2: import "github.com/google/addlicense" is a program, not an importable package

EDIT: Actually, the tools.go solution works if I put it in the root. The compiler therefore won't reach that file, but it's still considered for go.mod. I think this solution is good enough for now. The above issue is marked for milestone 1.14, so maybe we can revisit this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.