Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append SSH Username to subdomain #62

Closed
buffcode opened this issue Dec 19, 2019 · 1 comment · Fixed by #63
Closed

Append SSH Username to subdomain #62

buffcode opened this issue Dec 19, 2019 · 1 comment · Fixed by #63
Labels

Comments

@buffcode
Copy link
Contributor

@buffcode buffcode commented Dec 19, 2019

It would be nice to have the option to append the SSH username to the subdomain.
This way a multi-user team that works on the same project could use the same subdomain and would not get a random hosts assigned.

Example (current):

  • User Alice wants to expose "project" and receives project.ssi.sh
  • User Bob wants to expose "project" and receives 52f.ssi.sh

The next day Bob wakes up early:

  • User Bob wants to expose "project" and receives project.ssi.sh
  • User Alice wants to expose "project" and receives 7km.ssi.sh

=> Links / webhooks etc. for both of them are broken

Example (proposal):

  • User Alice wants to expose "project" and receives project-alice.ssi.sh
  • User Bob wants to expose "project" and receives project-bob.ssi.sh

This feature would be opt-in per instance and ensures, that a developer does not always need to care of making the hostname unique enough in order to receive a stable hostname. Of course there is no garantuee and the fallback will still generate a random hostname. But this will decrease the likelihood of collisions.

@antoniomika

This comment has been minimized.

Copy link
Owner

@antoniomika antoniomika commented Dec 20, 2019

Hi @buffcode thanks for the issue! I think this could be a cool feature, I'm just trying to think if there is a different use case for the username. I can't really think of a specific place for it, but regardless we could make this feature available behind a flag. Do you have any other thoughts on this?

antoniomika added a commit that referenced this issue Dec 22, 2019
fork04 added a commit to fork04/sish that referenced this issue Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.