Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude .git from docker image #21

Merged
merged 1 commit into from Sep 27, 2019

Conversation

@glensc
Copy link
Contributor

commented Sep 13, 2019

You do not want .git dir included in docker image. It may accidentally reveal something secret, git stash or other branches from example.

@antoniomika

This comment has been minimized.

Copy link
Owner

commented Sep 21, 2019

Thanks for the PR! Is there a reason you decided to prepend the .dockerignore file off of the / directory?

@glensc

This comment has been minimized.

Copy link
Contributor Author

commented Sep 23, 2019

Yes, as the path has meaning in the root of the folder, not to exclude unwanted files. for example, placing this file to subfolder will make easier to spot the mistakenly placed file.

For example, docs/.dockerignore will not be ignored in this configuration, or src/keys/foo.c

Probably should have made two commits: one commit for each change :)

Copy link
Owner

left a comment

👍

@antoniomika antoniomika merged commit e6f0e32 into antoniomika:master Sep 27, 2019
@glensc glensc deleted the glensc:docker-ignore branch Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.