Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a better way to distinguish between GTK+ and relm widgets in the view! macro #20

Closed
antoyo opened this issue Apr 21, 2017 · 2 comments
Labels
Milestone

Comments

@antoyo
Copy link
Owner

@antoyo antoyo commented Apr 21, 2017

Currently, a widget with a module separator like gtk::Button is considered a gtk widget while one without is considered a relm widget.
This is confusing.
I cannot check for the gtk prefix because other crates can provide gtk widgets like webkit2gtk.

An idea is to require to prepend a symbol in front a relm widgets like @Button.
I don't like this idea since it makes a distinction between gtk and relm widgets.

@antoyo antoyo added the easy label Apr 22, 2017
@antoyo antoyo added this to the 1.0 milestone Apr 4, 2018
@antoyo antoyo mentioned this issue Apr 4, 2018
15 of 39 tasks complete
@antoyo
Copy link
Owner Author

@antoyo antoyo commented Nov 17, 2018

Trying to create traits that will be used for both gtk and relm widgets in order to keep the same syntax.

@antoyo
Copy link
Owner Author

@antoyo antoyo commented Nov 18, 2018

Fixed by #149.
Finally, I decided to allow the use of the $ symbol to be able to use a path for the name of a relm widget.
The old syntax (identifier) still works for relm widget to maintain backward compatibility.

@antoyo antoyo closed this Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant