New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI tests #100

Merged
merged 72 commits into from Apr 20, 2018

Conversation

Projects
None yet
2 participants
@antoyo
Owner

antoyo commented Apr 4, 2018

@Eijebong Here it is. What do you think?

I wonder if there's a better way to only generate code in test than having a feature.
It looks very annoying to have a feature.

Issues:

  • Need to create a new observer everytime. (Cannot reproduce, check last commit.)
  • Bug when we have a #[cfg(test)] on a variant.
  • Cannot use Foo::Bar in observer_wait!.

@antoyo antoyo referenced this pull request Apr 4, 2018

Closed

Develop a GUI functional testing crate #7

14 of 14 tasks complete
@antoyo

This comment has been minimized.

Owner

antoyo commented Apr 5, 2018

@Eijebong I've removed the feature which was actually useless, indeed.
Also, I updated the test to show how to access the model.
Do you have enough for your needs?

@Eijebong

This comment has been minimized.

Contributor

Eijebong commented Apr 5, 2018

That failure is legit (also I have a Component in my test window so right now I can't even try this :/)

@antoyo

This comment has been minimized.

Owner

antoyo commented Apr 5, 2018

@Eijebong I added an Observer abstraction and macros to simplify their usage that will probably be very useful for your use case.
Let me know what you think of this abstraction.

@antoyo antoyo referenced this pull request Apr 20, 2018

Closed

Clean-up the examples #103

antoyo added some commits Apr 20, 2018

Revert "Add tests in AppVeyor"
This reverts commit 7ba698e.

@antoyo antoyo merged commit cc34b90 into master Apr 20, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@antoyo antoyo deleted the fix/ui-tests branch Apr 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment