Fix panic in stats.calculateRuleDiff #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The process would panic when it calculates stats of a rule that is newly added to an existing NetworkPolicy and the stats is zero. Signed-off-by: Quan Tian <qtian@vmware.com>
|
This needs to be backported to at least v1.2 as NetworkPolicyStats is enabled by default in it, and can be backported to v1.0 and v1.1. |
|
/test-all |
Codecov Report
@@ Coverage Diff @@
## main #2495 +/- ##
==========================================
+ Coverage 59.82% 59.85% +0.02%
==========================================
Files 284 284
Lines 22168 22175 +7
==========================================
+ Hits 13263 13273 +10
+ Misses 7483 7481 -2
+ Partials 1422 1421 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
antoninbas
approved these changes
Jul 29, 2021
This was referenced Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process would panic when it calculates stats of a rule that is newly
added to an existing NetworkPolicy and the stats is zero.
Signed-off-by: Quan Tian qtian@vmware.com
Fixes #2494