Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove controlplane.antrea.tanzu.vmware.com/v1beta1 #2528

Merged
merged 1 commit into from Aug 3, 2021

Conversation

luolanzone
Copy link
Contributor

@luolanzone luolanzone commented Aug 3, 2021

Resolves #2483
Signed-off-by: Lan Luo luola@vmware.com

Resolves issue antrea-io#2483
Signed-off-by: Lan Luo <luola@vmware.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2021

Codecov Report

Merging #2528 (7f93515) into main (d0d377e) will increase coverage by 22.88%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2528       +/-   ##
===========================================
+ Coverage   42.02%   64.91%   +22.88%     
===========================================
  Files         148      281      +133     
  Lines       18131    25464     +7333     
===========================================
+ Hits         7620    16529     +8909     
+ Misses       9828     7389     -2439     
- Partials      683     1546      +863     
Flag Coverage Δ
e2e-tests 55.82% <100.00%> (?)
kind-e2e-tests 46.98% <100.00%> (?)
unit-tests 42.21% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/certificate/cacert_controller.go 67.79% <ø> (+59.18%) ⬆️
pkg/legacyclient/clientset/versioned/clientset.go 28.76% <ø> (ø)
...egacyclient/clientset/versioned/scheme/register.go 100.00% <ø> (ø)
pkg/apiserver/apiserver.go 88.37% <100.00%> (ø)
pkg/legacyapis/controlplane/install/install.go 100.00% <100.00%> (ø)
pkg/controller/egress/ipallocator/allocator.go 67.82% <0.00%> (-15.16%) ⬇️
pkg/controller/networkpolicy/endpoint_querier.go 77.64% <0.00%> (-13.79%) ⬇️
pkg/apis/controlplane/v1beta1/conversion.go 72.44% <0.00%> (-11.09%) ⬇️
pkg/controller/egress/controller.go 76.76% <0.00%> (-10.44%) ⬇️
pkg/apiserver/handlers/endpoint/handler.go 61.11% <0.00%> (-9.48%) ⬇️
... and 270 more

@hangyan
Copy link
Member

hangyan commented Aug 3, 2021

/lgtm

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@tnqn
Copy link
Member

tnqn commented Aug 3, 2021

Please update the descrption: Resolve issue #2483 => Resolves #2483 (I might have commented this a few times):

  1. The issue will have a hint "May be fixed by #xxx" in its abstract so people know there is already a PR for that issue.
  2. Merging the PR will close the issue automatically.

See using-keywords-in-issues-and-pull-requests.

@luolanzone
Copy link
Contributor Author

@tnqn thanks for the reminder, I just updated the PR description.

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, always feels great to remove old stuff :)

@antoninbas antoninbas added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API. label Aug 3, 2021
@antoninbas
Copy link
Contributor

/test-all

@antoninbas antoninbas merged commit 464a735 into antrea-io:main Aug 3, 2021
@luolanzone luolanzone deleted the remove-api branch August 4, 2021 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove controlplane.antrea.tanzu.vmware.com/v1beta1
5 participants