antrea-agent readiness probe tolerates longer disconnection #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/skip-all |
antoninbas
reviewed
Aug 4, 2021
Codecov Report
@@ Coverage Diff @@
## main #2535 +/- ##
==========================================
- Coverage 59.90% 59.79% -0.12%
==========================================
Files 281 281
Lines 22207 22239 +32
==========================================
- Hits 13304 13297 -7
- Misses 7481 7524 +43
+ Partials 1422 1418 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
In large-scale clusters, it may take 40~50 seconds for antrea-agent to reconnect to antrea service after antrea-controller restarts. antrea-agent shouldn't be reported as NotReady in this scenario, otherwise DaemonSet controller would restart them at once, as opposed to rolling update. Set failureThreshold to 8 so it can tolerate 70s of disconnection. Signed-off-by: Quan Tian <qtian@vmware.com>
tnqn
force-pushed
the
increase-failure-threshold
branch
from
0f55a62
to
788d6be
Compare
|
/test-all |
Yes, will do. |
antoninbas
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In large-scale clusters, it may take 40~50 seconds for antrea-agent to
reconnect to antrea service after antrea-controller restarts.
antrea-agent shouldn't be reported as NotReady in this scenario,
otherwise DaemonSet controller would restart them at once, as opposed
to rolling update. Set failureThreshold to 8 so it can tolerate 70s of
disconnection.
Signed-off-by: Quan Tian qtian@vmware.com
Fixes #2534
The purpose of antrea-agent's readiness probe is to make the status of antrea-agent visible, e.g. the connection with antrea-controller, and it's not for service loadbalancing/failover. So it should be fine to be less aggressive to update its ready status.