Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow Exporter] Fix missing template when sending first record #2546

Merged
merged 1 commit into from Aug 6, 2021

Conversation

zyiou
Copy link
Contributor

@zyiou zyiou commented Aug 6, 2021

fixes vmware/go-ipfix#235
fa.templateIDv4 and fa.templateIDv6 are not assigned with any value when first exporting the template records, which caused sanity check not getting passed when sending first record.

E0804 17:01:13.684657 1 flowaggregator.go:392] Error when sending expired flow records: callback execution failed for popped flow record with key: &{10.10.0.1 10.10.1.7 6 48022 4739}, record: &{0xc0002e9aa0 0xc00007a8c0 true 0 true true true}, error: error when doing sanity check:process: templateID 256 does not exist in exporting process

This PR fixes issue above by assign template ID before exporting templates.

Signed-off-by: zyiou <zyiou@vmware.com>
@zyiou zyiou added area/flow-visibility Issues or PRs related to flow visibility support in Antrea area/flow-visibility/exporter Issues or PRs related to the Flow Exporter functions in the Agent labels Aug 6, 2021
Copy link
Member

@srikartati srikartati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fa.templateIDv4 and fa.templateIDv6 are not assigned with correct value when first exporting the template records, which caused sanity check not getting passed when sending first record

In the above description, do you mean the template ID is not assigned with any value rather than an incorrect value. Is that correct?

@antoninbas
Copy link
Contributor

/test-all

@zyiou
Copy link
Contributor Author

zyiou commented Aug 6, 2021

LGTM

fa.templateIDv4 and fa.templateIDv6 are not assigned with correct value when first exporting the template records, which caused sanity check not getting passed when sending first record

In the above description, do you mean the template ID is not assigned with any value rather than an incorrect value. Is that correct?

Yes, updated the description. Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021

Codecov Report

Merging #2546 (b398012) into main (9ea4e86) will increase coverage by 6.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2546      +/-   ##
==========================================
+ Coverage   58.82%   64.86%   +6.04%     
==========================================
  Files         281      281              
  Lines       22271    25538    +3267     
==========================================
+ Hits        13101    16566    +3465     
+ Misses       7796     7428     -368     
- Partials     1374     1544     +170     
Flag Coverage Δ
e2e-tests 55.50% <66.66%> (?)
kind-e2e-tests 47.01% <62.50%> (+1.71%) ⬆️
unit-tests 42.25% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/flowaggregator/flowaggregator.go 66.21% <66.66%> (-0.21%) ⬇️
pkg/controller/egress/ipallocator/allocator.go 67.82% <0.00%> (-15.16%) ⬇️
pkg/controller/networkpolicy/endpoint_querier.go 77.64% <0.00%> (-13.79%) ⬇️
pkg/apis/controlplane/v1beta1/conversion.go 72.44% <0.00%> (-11.89%) ⬇️
pkg/legacyapis/core/v1alpha2/register.go 69.23% <0.00%> (-10.77%) ⬇️
pkg/controller/egress/controller.go 76.76% <0.00%> (-10.44%) ⬇️
pkg/apis/stats/register.go 71.42% <0.00%> (-10.39%) ⬇️
pkg/legacyapis/stats/register.go 71.42% <0.00%> (-10.39%) ⬇️
pkg/ovs/openflow/ofctrl_meter.go 33.84% <0.00%> (-10.16%) ⬇️
pkg/legacyapis/security/v1alpha1/register.go 73.33% <0.00%> (-10.00%) ⬇️
... and 266 more

@antoninbas
Copy link
Contributor

/test-e2e

@antoninbas antoninbas merged commit bde2877 into antrea-io:main Aug 6, 2021
annakhm pushed a commit to annakhm/antrea that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/flow-visibility/exporter Issues or PRs related to the Flow Exporter functions in the Agent area/flow-visibility Issues or PRs related to flow visibility support in Antrea
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seeing send error in exporting process in Antrea setups
4 participants