New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flow Exporter] Fix missing template when sending first record #2546
Conversation
Signed-off-by: zyiou <zyiou@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fa.templateIDv4 and fa.templateIDv6 are not assigned with correct value when first exporting the template records, which caused sanity check not getting passed when sending first record
In the above description, do you mean the template ID is not assigned with any value rather than an incorrect value. Is that correct?
|
/test-all |
Yes, updated the description. Thanks! |
Codecov Report
@@ Coverage Diff @@
## main #2546 +/- ##
==========================================
+ Coverage 58.82% 64.86% +6.04%
==========================================
Files 281 281
Lines 22271 25538 +3267
==========================================
+ Hits 13101 16566 +3465
+ Misses 7796 7428 -368
- Partials 1374 1544 +170
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test-e2e |
Signed-off-by: zyiou <zyiou@vmware.com>
fixes vmware/go-ipfix#235
fa.templateIDv4andfa.templateIDv6are not assigned with any value when first exporting the template records, which caused sanity check not getting passed when sending first record.This PR fixes issue above by assign template ID before exporting templates.