Fix panic bug in Antrea Policy #2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2730 +/- ##
==========================================
+ Coverage 59.50% 65.82% +6.32%
==========================================
Files 285 285
Lines 23020 26389 +3369
==========================================
+ Hits 13697 17371 +3674
+ Misses 7865 7394 -471
- Partials 1458 1624 +166
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test-all |
abhiraut
previously approved these changes
Sep 8, 2021
pkg/agent/openflow/network_policy.go
Outdated
| @@ -1511,6 +1514,9 @@ func (c *client) updateConjunctionActionFlows(conj *policyRuleConjunction, updat | |||
| func (c *client) updateConjunctionMatchFlows(conj *policyRuleConjunction, newPriority uint16) { | |||
| allClause := []*clause{conj.fromClause, conj.toClause, conj.serviceClause} | |||
| for _, clause := range allClause { | |||
There was a problem hiding this comment.
not introduced by your change; but the var clause is used for the struct and for the looping var
qiyueyao
previously approved these changes
Sep 8, 2021
There was a problem hiding this comment.
LGTM, not related just a quick question do we need to check nil before getting flow priority?
func (c *client) GetPolicyInfoFromConjunction(ruleID uint32) (string, string) {
conjunction := c.getPolicyRuleConjunction(ruleID)
priorities := conjunction.ActionFlowPriorities()
if conjunction == nil || len(priorities) == 0 {
return "", ""
}
return conjunction.npRef.ToString(), priorities[0]
}
Thanks!
GraysonWu
previously approved these changes
Sep 9, 2021
Greate catch, I would change it together. |
wenyingd
force-pushed
the
bugfix_2832923
branch
from
b456068
to
a89edb4
Compare
|
/test-all |
tnqn
previously approved these changes
Sep 9, 2021
abhiraut
previously approved these changes
Sep 9, 2021
qiyueyao
previously approved these changes
Sep 9, 2021
Check if the clause pointer is nil before looping the matches. Signed-off-by: wenyingd <wenyingd@vmware.com>
wenyingd
force-pushed
the
bugfix_2832923
branch
from
a89edb4
to
de43b1e
Compare
|
/test-all |
|
@tnqn Shall I backport this PR to original releases? |
|
@wenyingd please backport to any release which has this bug, starting with v0.13 |
This was referenced Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the clause pointer is nil before looping the matches.
Fixes #2729
Signed-off-by: wenyingd wenyingd@vmware.com