Reduce memory consumption of supportbundle command #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2813 +/- ##
==========================================
- Coverage 61.49% 59.09% -2.41%
==========================================
Files 284 284
Lines 23549 23549
==========================================
- Hits 14482 13916 -566
- Misses 7506 8151 +645
+ Partials 1561 1482 -79
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tnqn
force-pushed
the
reduce-supportbundle-memory
branch
from
4d90765
to
9a75991
Compare
Instead of creating a buffer which buffers all converted objects and outputs to file together, this patch traverses the item list, and converts and outputs items one by one. Signed-off-by: Quan Tian <qtian@vmware.com>
tnqn
force-pushed
the
reduce-supportbundle-memory
branch
from
9a75991
to
420e777
Compare
|
/test-all |
Merged
antoninbas
approved these changes
Sep 22, 2021
mengdie-song
approved these changes
Sep 23, 2021
|
/lgtm |
hangyan
approved these changes
Sep 23, 2021
|
/test-conformance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a buffer which buffers all converted objects and
outputs to file together, this patch traverses the item list, and
converts and outputs items one by one.
Signed-off-by: Quan Tian qtian@vmware.com
In a scale cluster with 26,000+Pods, the memory usage is reduced from
16GB to 600MB.