Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #2813: Reduce memory consumption of supportbundle command #2821

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Sep 23, 2021

Cherry pick of #2813 on release-1.2.

#2813: Reduce memory consumption of supportbundle command

For details on the cherry pick process, see the cherry pick requests page.

Instead of creating a buffer which buffers all converted objects and
outputs to file together, this patch traverses the item list, and
converts and outputs items one by one.

Signed-off-by: Quan Tian <qtian@vmware.com>
@tnqn tnqn added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Sep 23, 2021
@tnqn
Copy link
Member Author

tnqn commented Sep 23, 2021

/test-all

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #2821 (b5b1cc7) into release-1.2 (2a9deb8) will increase coverage by 5.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.2    #2821      +/-   ##
===============================================
+ Coverage        60.27%   65.31%   +5.03%     
===============================================
  Files              284      284              
  Lines            22384    25664    +3280     
===============================================
+ Hits             13492    16762    +3270     
+ Misses            7449     7338     -111     
- Partials          1443     1564     +121     
Flag Coverage Δ
e2e-tests 55.95% <ø> (?)
kind-e2e-tests 47.09% <ø> (+0.38%) ⬆️
unit-tests 42.76% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/egress/ipallocator/allocator.go 67.82% <0.00%> (-15.16%) ⬇️
pkg/controller/networkpolicy/endpoint_querier.go 77.64% <0.00%> (-13.79%) ⬇️
pkg/apis/controlplane/v1beta1/conversion.go 72.44% <0.00%> (-11.89%) ⬇️
pkg/legacyapis/core/v1alpha2/register.go 69.23% <0.00%> (-10.77%) ⬇️
pkg/controller/egress/controller.go 76.76% <0.00%> (-10.44%) ⬇️
pkg/apis/stats/register.go 71.42% <0.00%> (-10.39%) ⬇️
pkg/legacyapis/stats/register.go 71.42% <0.00%> (-10.39%) ⬇️
pkg/ovs/openflow/ofctrl_meter.go 33.84% <0.00%> (-10.16%) ⬇️
pkg/legacyapis/security/v1alpha1/register.go 73.33% <0.00%> (-10.00%) ⬇️
pkg/agent/config/traffic_encap_mode.go 91.30% <0.00%> (-8.70%) ⬇️
... and 268 more

@tnqn tnqn merged commit 5dab0da into antrea-io:release-1.2 Sep 24, 2021
@tnqn tnqn deleted the automated-cherry-pick-of-#2813-upstream-release-1.2 branch September 24, 2021 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants