New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Node TransportIP interface to send EgressIP gratuitous arp #2845
Conversation
…a-io#2845) 1. Use transportInterface as Egress external interface to send EgressIP gratuitous arp. 2. Remove unused feild in Cluster struct. Signed-off-by: Wu zhengdong <zhengdong.wu@transwarp.io>
Codecov Report
@@ Coverage Diff @@
## main #2845 +/- ##
===========================================
+ Coverage 40.90% 61.61% +20.71%
===========================================
Files 158 284 +126
Lines 19539 23469 +3930
===========================================
+ Hits 7992 14460 +6468
+ Misses 10798 7461 -3337
- Partials 749 1548 +799
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
Code LGTM. Two comments for commit message:
|
1. Use transportInterface as Egress external interface to send EgressIP gratuitous arp. 2. Remove unused field in Cluster struct. Signed-off-by: Wu zhengdong <zhengdong.wu@transwarp.io>
@tnqn Thanks for the review, updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/test-all |
|
/test-ipv6-only |
Use transportInterface as Egress external interface to send EgressIP gratuitous arp.
Remove unused field in Cluster struct.
Signed-off-by: Wu zhengdong zhengdong.wu@transwarp.io