New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude special device IP Addresses for Egress. #2930
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-all |
Codecov Report
@@ Coverage Diff @@
## main #2930 +/- ##
===========================================
+ Coverage 40.58% 61.58% +21.00%
===========================================
Files 158 283 +125
Lines 19952 23822 +3870
===========================================
+ Hits 8097 14671 +6574
+ Misses 11083 7579 -3504
- Partials 772 1572 +800
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tnqn
reviewed
Oct 25, 2021
|
/test-all |
tnqn
reviewed
Oct 28, 2021
Since the IPs of kube-ipvs0 dummy device cannot be used for Egress, so exclude kube-ipvs0 dummy device IP Addresses for Egress. Signed-off-by: Wu zhengdong <zhengdong.wu@transwarp.io>
|
/test-all |
tnqn
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/test-integration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the IPs of kube-ipvs0 dummy device cannot be used for Egress, so exclude kube-ipvs0 dummy device IP Addresses for Egress.
Fixes: #2910
Signed-off-by: Wu zhengdong zhengdong.wu@transwarp.io