Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude special device IP Addresses for Egress. #2930

Merged
merged 1 commit into from Oct 29, 2021
Merged

Conversation

Jexf
Copy link
Member

@Jexf Jexf commented Oct 25, 2021

Since the IPs of kube-ipvs0 dummy device cannot be used for Egress, so exclude kube-ipvs0 dummy device IP Addresses for Egress.

Fixes: #2910

Signed-off-by: Wu zhengdong zhengdong.wu@transwarp.io

@Jexf
Copy link
Member Author

Jexf commented Oct 25, 2021

/test-all

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2021

Codecov Report

Merging #2930 (53e034d) into main (f45c104) will increase coverage by 21.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2930       +/-   ##
===========================================
+ Coverage   40.58%   61.58%   +21.00%     
===========================================
  Files         158      283      +125     
  Lines       19952    23822     +3870     
===========================================
+ Hits         8097    14671     +6574     
+ Misses      11083     7579     -3504     
- Partials      772     1572      +800     
Flag Coverage Δ
kind-e2e-tests 49.29% <0.00%> (?)
unit-tests 40.57% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...agent/controller/egress/local_ip_detector_linux.go 0.00% <0.00%> (ø)
pkg/apiserver/handlers/endpoint/handler.go 58.82% <0.00%> (-11.77%) ⬇️
pkg/apiserver/handlers/webhook/convert_crd.go 2.56% <0.00%> (ø)
pkg/apiserver/handlers/webhook/mutation_labels.go 24.71% <0.00%> (ø)
pkg/apiserver/registry/networkpolicy/util.go 100.00% <0.00%> (ø)
pkg/legacyapis/core/v1alpha2/webhook.go 0.00% <0.00%> (ø)
...t/informers/externalversions/security/interface.go 100.00% <0.00%> (ø)
...ntset/versioned/typed/core/v1alpha2/core_client.go 54.16% <0.00%> (ø)
pkg/apis/crd/v1alpha2/register.go 85.71% <0.00%> (ø)
pkg/agent/cniserver/ipam/ipam_delegator.go 48.83% <0.00%> (ø)
... and 232 more

@Jexf Jexf changed the title Exclude kube-ipvs0 IP Addresses by Egress. Exclude special device IP Addresses for Egress. Oct 28, 2021
@Jexf
Copy link
Member Author

Jexf commented Oct 28, 2021

/test-all

Since the IPs of kube-ipvs0 dummy device cannot be used for Egress,
so exclude kube-ipvs0 dummy device IP Addresses for Egress.

Signed-off-by: Wu zhengdong <zhengdong.wu@transwarp.io>
@Jexf
Copy link
Member Author

Jexf commented Oct 29, 2021

/test-all

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Oct 29, 2021

/test-integration

@tnqn tnqn merged commit b90cbe9 into antrea-io:main Oct 29, 2021
@Jexf Jexf deleted the egress-fix branch November 1, 2021 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Antrea Egress only watch the special interface IP Addresses events
3 participants