Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Add a PS parameter to renew ipconfig #2955

Merged
merged 1 commit into from Nov 3, 2021

Conversation

wenyingd
Copy link
Contributor

@wenyingd wenyingd commented Nov 1, 2021

Add a parameter in the powershell script "Clean-AntreaNetwork.ps1" to
control if renewing ipconfig or not. The default value is $false.

Fixes #2954

Signed-off-by: wenyingd wenyingd@vmware.com

Add a parameter in the powershell script "Clean-AntreaNetwork.ps1" to
control if renewing ipconfig or not. The default value is $false.

Signed-off-by: wenyingd <wenyingd@vmware.com>
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Nov 2, 2021

@wenyingd Is the script used in any CI job? Do we need to run windows test for it?

/skip-all

@wenyingd
Copy link
Contributor Author

wenyingd commented Nov 3, 2021

@wenyingd Is the script used in any CI job? Do we need to run windows test for it?

/skip-all

No, it is not tested in any CI job. But the script is already verified in TKGM setup.

@wenyingd
Copy link
Contributor Author

wenyingd commented Nov 3, 2021

/skip-windows-all
/skip-ipv6-all
/skip-ipv6-only-all

@tnqn tnqn merged commit dddd79a into antrea-io:main Nov 3, 2021
@wenyingd wenyingd deleted the issue_2954 branch August 15, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip "ipconfig /renew" on shutdown in script Clean-AntreaNetwork.ps1
3 participants