Make reject action work in AntreaIPAM mode #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-flexible-ipam-e2e |
GraysonWu
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3003 +/- ##
==========================================
- Coverage 60.61% 59.78% -0.83%
==========================================
Files 292 292
Lines 24708 24709 +1
==========================================
- Hits 14976 14772 -204
- Misses 8092 8317 +225
+ Partials 1640 1620 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
GraysonWu
force-pushed
the
fix-reject-ipam
branch
3 times, most recently
from
6e4928b
to
ec0ec4f
Compare
|
/test-flexible-ipam-e2e |
GraysonWu
force-pushed
the
fix-reject-ipam
branch
from
ec0ec4f
to
1dd87fe
Compare
|
/test-flexible-ipam-e2e |
GraysonWu
force-pushed
the
fix-reject-ipam
branch
from
1dd87fe
to
89909f3
Compare
GraysonWu
changed the title
|
/test-flexible-ipam-e2e |
Signed-off-by: wgrayson <wgrayson@vmware.com>
GraysonWu
force-pushed
the
fix-reject-ipam
branch
from
ddc3989
to
04a3614
Compare
|
/test-e2e |
|
/test-integration |
|
/skip-conformance |
|
@GraysonWu "Fixes issue #xxx" won't close the issue automatically, please just write "Fixes #xxx" next time. |
Got it. Thanks for reminding me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #2979.
For this issue, after investigation, I noticed that only intra-Node Pod-to-Pod traffic with ingress reject policy will fail.
The root cause of this issue is that in AntreaIPAM mode, MAC addresses will always be re-written as
srcMAC=localGatewayMAC, dstMAC=dstPodInterfaceMACin L3ForwardingTable. https://github.com/antrea-io/antrea/blob/main/pkg/agent/openflow/pipeline.go#L1150-L1152.Previous reject logic for intra-Node Pod-to-Pod case is that directly output the reject response to the OF port of the dstPod of the reject response. This could work for egress policies because the packet hasn't reached L3ForwardingTable. But for ingress policies, MAC addresses haven't re-written. The generated reject response will use localGatewayMAC as dstMAC. When the client receives this response, it won't treat it as a correct response to its request.
This PR changed the reject logic for Pod-to-Pod intra-Node case to resubmit the packet to L3ForwardingTable instead of directly output to an OF port. So in AntreaIPAM mode, L3ForwardingTable could re-write MAC addresses to a correct state. And it also can work when not in AntreaIPAM mode.