Add Go benchmark test #3004
Merged
Add Go benchmark test #3004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See the benchmarks test duration: |
Codecov Report
@@ Coverage Diff @@
## main #3004 +/- ##
===========================================
+ Coverage 40.17% 61.01% +20.83%
===========================================
Files 166 289 +123
Lines 20713 24548 +3835
===========================================
+ Hits 8322 14978 +6656
+ Misses 11580 7941 -3639
- Partials 811 1629 +818
Flags with carried forward coverage won't be shown. Click here to find out more.
|
antoninbas
reviewed
Nov 8, 2021
.github/workflows/go.yml
Outdated
| - name: Check-out code | ||
| uses: actions/checkout@v2 | ||
| - name: Run Go benchmark test | ||
| run: go test -run '^$' -bench . -benchtime 1s -timeout 10m -cpu 4 -v -benchmem ./pkg/... |
There was a problem hiding this comment.
why 1s instead of 1x? do you need to run each benchmark more than once? I think 1s is actually the default for -benchtime
There was a problem hiding this comment.
Yes, 1s is the default for -benchtime, 1x is more reasonable.
src/testing/benchmark.go
func initBenchmarkFlags() {
matchBenchmarks = flag.String("test.bench", "", "run only benchmarks matching `regexp`")
benchmarkMemory = flag.Bool("test.benchmem", false, "print memory allocations for benchmarks")
flag.Var(&benchTime, "test.benchtime", "run each benchmark for duration `d`")
}
var (
matchBenchmarks *string
benchmarkMemory *bool
benchTime = durationOrCountFlag{d: 1 * time.Second} // changed during test of testing package
)
Run the benchmarks once for each PR. Fixes antrea-io#2984 Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
antoninbas
reviewed
Nov 9, 2021
|
/skip-all |
|
/skip-e2e |
jianjuns
pushed a commit
to jianjuns/antrea
that referenced
this pull request
Dec 22, 2021
Run the benchmarks once for each PR. Fixes antrea-io#2984 Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the benchmarks once for each PR.
Fixes #2984
Signed-off-by: Wenqi Qiu wenqiq@vmware.com