Use go 1.17 to build release assets #3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, I forgot to use the setup-go action for that workflow when I added it, which means that we have been using the default Go version provided by the Github runners since the beginning. The default Go version is currently 1.15 (https://github.com/actions/virtual-environments/blob/8fd74ebe0f0706cb6aa2cc01f5863961d01173e9/images/linux/toolsets/toolset-2004.json#L52), which is not maintained. We now use the setup-go action to use the same Go version as all other workflows (1.17). Signed-off-by: Antonin Bas <abas@vmware.com>
antoninbas
added
the
area/build-release
|
Thanks @liu4480 for reporting this issue |
|
/skip-all |
Codecov Report
@@ Coverage Diff @@
## main #3007 +/- ##
==========================================
- Coverage 61.06% 59.71% -1.36%
==========================================
Files 289 289
Lines 24548 24548
==========================================
- Hits 14991 14658 -333
- Misses 7938 8289 +351
+ Partials 1619 1601 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Cherry-picking this to 1.4 and 1.3 (1.3 is when we switched from Go 1.15 to 1.17) |
This was referenced Nov 9, 2021
wenyingd
pushed a commit
to wenyingd/antrea
that referenced
this pull request
Nov 15, 2021
For some reason, I forgot to use the setup-go action for that workflow when I added it, which means that we have been using the default Go version provided by the Github runners since the beginning. The default Go version is currently 1.15 (https://github.com/actions/virtual-environments/blob/8fd74ebe0f0706cb6aa2cc01f5863961d01173e9/images/linux/toolsets/toolset-2004.json#L52), which is not maintained. We now use the setup-go action to use the same Go version as all other workflows (1.17). Signed-off-by: Antonin Bas <abas@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, I forgot to use the setup-go action for that workflow
when I added it, which means that we have been using the default Go
version provided by the Github runners since the beginning. The default
Go version is currently 1.15, which is not maintained.
We now use the setup-go action to use the same Go version as all other
workflows (1.17).
Signed-off-by: Antonin Bas abas@vmware.com