Fix ClusterGroup realization status logic #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3030 +/- ##
==========================================
+ Coverage 60.93% 61.02% +0.09%
==========================================
Files 292 292
Lines 24708 24721 +13
==========================================
+ Hits 15056 15087 +31
+ Misses 8015 7993 -22
- Partials 1637 1641 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Dyanngg
force-pushed
the
fix-group-member-status
branch
2 times, most recently
from
4fbf1cf
to
1281e30
Compare
tnqn
reviewed
Nov 18, 2021
| @@ -202,6 +202,10 @@ type NetworkPolicyController struct { | |||
| // concurrent access during updates to the internal NetworkPolicy object. | |||
| internalNetworkPolicyMutex sync.RWMutex | |||
|
|
|||
| // internalGroupMutex protects the internalGroupStore from current access | |||
There was a problem hiding this comment.
concurrent.
Why the mutex is needed? internalGroupStore itself is thread-safe. You may want to prevent race condition between the event handlers and syncWorkers but the critical sections in this commit only protects the store operations, which is duplicate with the lock in the store itself.
There was a problem hiding this comment.
Thanks for the reminder. Removed the group mutex
Signed-off-by: Yang Ding <dingyang@vmware.com>
Dyanngg
force-pushed
the
fix-group-member-status
branch
from
1281e30
to
df9dad9
Compare
|
/test-all |
antoninbas
pushed a commit
that referenced
this pull request
Oct 20, 2022
Signed-off-by: Yang Ding <dingyang@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3002.
ClusterGroup with child groups should only be considered groupMembersComputed after all its child groups are created and processed.
Signed-off-by: Yang Ding dingyang@vmware.com