Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reason field in antctl traceflow command output #3175

Merged
merged 1 commit into from Jan 7, 2022

Conversation

Jexf
Copy link
Member

@Jexf Jexf commented Jan 6, 2022

Sometimes the traceflow function may be used incorrectly, so need to display the reason for the failure.

Signed-off-by: Wu zhengdong zhengdong.wu@transwarp.io

@Jexf Jexf requested a review from jianjuns January 6, 2022 09:48
@Jexf Jexf added the area/component/antctl Issues or PRs releated to the command line interface component label Jan 6, 2022
@Jexf Jexf requested a review from tnqn January 6, 2022 09:49
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2022

Codecov Report

Merging #3175 (dd983ef) into main (0be629b) will decrease coverage by 1.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3175      +/-   ##
==========================================
- Coverage   60.42%   59.28%   -1.14%     
==========================================
  Files         297      297              
  Lines       25287    25288       +1     
==========================================
- Hits        15279    14993     -286     
- Misses       8336     8646     +310     
+ Partials     1672     1649      -23     
Flag Coverage Δ
kind-e2e-tests 45.77% <ø> (-1.16%) ⬇️
unit-tests 40.30% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/antctl/raw/traceflow/command.go 24.30% <0.00%> (-0.10%) ⬇️
pkg/agent/util/net.go 16.32% <0.00%> (-22.45%) ⬇️
pkg/agent/route/route_linux.go 27.17% <0.00%> (-19.50%) ⬇️
pkg/apiserver/handlers/endpoint/handler.go 58.82% <0.00%> (-11.77%) ⬇️
pkg/agent/util/ipset/ipset.go 61.53% <0.00%> (-7.70%) ⬇️
pkg/apiserver/certificate/certificate.go 69.86% <0.00%> (-6.85%) ⬇️
pkg/agent/openflow/pipeline.go 66.36% <0.00%> (-6.17%) ⬇️
pkg/util/k8s/client.go 46.34% <0.00%> (-4.88%) ⬇️
pkg/agent/proxy/types/groupcounter.go 90.56% <0.00%> (-3.78%) ⬇️
pkg/agent/client.go 77.41% <0.00%> (-3.23%) ⬇️
... and 11 more

Sometimes the traceflow function may be used incorrectly, so need to
display the reason for the failure.

Signed-off-by: Wu zhengdong <zhengdong.wu@transwarp.io>
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Jan 7, 2022

/skip-all

@tnqn tnqn merged commit a8ab81d into antrea-io:main Jan 7, 2022
@Jexf Jexf deleted the traceflow branch January 7, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/component/antctl Issues or PRs releated to the command line interface component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants