Add ClickHouse Client #3196
Merged
Add ClickHouse Client #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsquan171
force-pushed
the
ch-client
branch
4 times, most recently
from
1cdd123
to
f654906
Compare
Codecov Report
@@ Coverage Diff @@
## main #3196 +/- ##
==========================================
- Coverage 65.58% 62.91% -2.68%
==========================================
Files 277 278 +1
Lines 27264 37801 +10537
==========================================
+ Hits 17881 23782 +5901
- Misses 7483 12054 +4571
- Partials 1900 1965 +65
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dreamtalen
reviewed
Jan 14, 2022
wsquan171
force-pushed
the
ch-client
branch
7 times, most recently
from
b3adb20
to
ef23a7d
Compare
tnqn
reviewed
Jan 26, 2022
heanlan
reviewed
Jan 27, 2022
yanjunz97
reviewed
Jan 29, 2022
heanlan
reviewed
Feb 15, 2022
|
Hi @tnqn , could you please approve running workflows for this PR? Thanks. |
Done, and invited @wsquan171 to the organization. |
dreamtalen
reviewed
Feb 17, 2022
jianjuns
reviewed
Feb 25, 2022
wsquan171
force-pushed
the
ch-client
branch
2 times, most recently
from
a62b9e3
to
33f440f
Compare
Signed-off-by: Shawn Wang <wshaoquan@vmware.com>
Signed-off-by: heanlan <hanlan@vmware.com>
This change adds the following changes to CH client options: 1. adds new option "commitInterval" for customizing batch commit interval from CH client 2. sets default values for database, db url, commit interval when clickHouse config exists in FA configMap. 3. makes externalFlowCollectorAddr optional when CH is configured 4. adds an explicit switch for turning on CH exporting, for more intuit conf editing. 5. moves previous IPFIX and JSON collector options to a dedicated section. Signed-off-by: Shawn Wang <wshaoquan@vmware.com>
Signed-off-by: Shawn Wang <wshaoquan@vmware.com>
|
/test-all |
|
/test-conformance |
|
/test-e2e |
|
/test-networkpolicy |
antoninbas
approved these changes
Mar 24, 2022
|
/test-integration |
8 similar comments
|
/test-integration |
|
/test-integration |
|
/test-integration |
|
/test-integration |
|
/test-integration |
|
/test-integration |
|
/test-integration |
|
/test-integration |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shawn Wang wshaoquan@vmware.com