Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log error when Service for Endpoints is not found #3256

Merged
merged 1 commit into from Feb 9, 2022

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Jan 27, 2022

It's possible that some Endpoints don't have Service. For example,
kube-scheduler and kube-controller-manager may use Endpoints for leader
election.

Signed-off-by: Quan Tian qtian@vmware.com

Fixes #3255

It's possible that some Endpoints don't have Service. For example,
kube-scheduler and kube-controller-manager may use Endpoints for leader
election.

Signed-off-by: Quan Tian <qtian@vmware.com>
@tnqn tnqn requested a review from xliuxu January 27, 2022 04:38
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

Merging #3256 (a6d1122) into main (9809991) will decrease coverage by 6.80%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3256      +/-   ##
==========================================
- Coverage   59.66%   52.85%   -6.81%     
==========================================
  Files         331      462     +131     
  Lines       28437    54628   +26191     
==========================================
+ Hits        16966    28872   +11906     
- Misses       9595    23270   +13675     
- Partials     1876     2486     +610     
Flag Coverage Δ
e2e-tests 52.18% <100.00%> (?)
integration-tests 34.02% <ø> (?)
kind-e2e-tests 47.90% <100.00%> (+0.27%) ⬆️
unit-tests 41.35% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/agent/controller/serviceexternalip/controller.go 80.82% <100.00%> (-0.04%) ⬇️
pkg/agent/cniserver/pod_configuration_linux.go 26.31% <0.00%> (-40.36%) ⬇️
pkg/controller/ipam/antrea_ipam_controller.go 48.71% <0.00%> (-31.57%) ⬇️
pkg/controller/networkpolicy/endpoint_querier.go 61.46% <0.00%> (-29.97%) ⬇️
pkg/controller/egress/controller.go 61.11% <0.00%> (-27.34%) ⬇️
.../registry/networkpolicy/clustergroupmember/rest.go 64.28% <0.00%> (-23.95%) ⬇️
pkg/agent/cniserver/ipam/antrea_ipam.go 55.55% <0.00%> (-23.62%) ⬇️
pkg/agent/cniserver/ipam/antrea_ipam_controller.go 56.30% <0.00%> (-23.46%) ⬇️
pkg/agent/util/ethtool/ethtool_linux.go 46.66% <0.00%> (-23.34%) ⬇️
pkg/controller/ipam/validate.go 57.14% <0.00%> (-22.86%) ⬇️
... and 425 more

@xliuxu
Copy link
Contributor

xliuxu commented Jan 30, 2022

Thanks for the explanation.

@tnqn tnqn added the action/release-note Indicates a PR that should be included in release notes. label Feb 7, 2022
@tnqn
Copy link
Member Author

tnqn commented Feb 8, 2022

/test-all

@tnqn tnqn merged commit 70fac83 into antrea-io:main Feb 9, 2022
@tnqn tnqn deleted the service-notfound branch February 9, 2022 02:24
yanjunz97 pushed a commit to yanjunz97/antrea that referenced this pull request Feb 14, 2022
)

It's possible that some Endpoints don't have Service. For example,
kube-scheduler and kube-controller-manager may use Endpoints for leader
election.

Signed-off-by: Quan Tian <qtian@vmware.com>
bangqipropel pushed a commit to bangqipropel/antrea that referenced this pull request Mar 2, 2022
)

It's possible that some Endpoints don't have Service. For example,
kube-scheduler and kube-controller-manager may use Endpoints for leader
election.

Signed-off-by: Quan Tian <qtian@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/release-note Indicates a PR that should be included in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

antrea-agent spamming "failed to get Service for Endpoint" error log
3 participants