Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CT mark matching without range in flow exporter #3348

Merged
merged 1 commit into from Feb 26, 2022

Conversation

hongliangl
Copy link
Contributor

@hongliangl hongliangl commented Feb 23, 2022

  • Fix CT mark matching without range in
    pkg/agent/flowexporter/exporter/exporter.go
  • Fix typo in test/e2e/connectivity_test.go
  • Remove extra blank line in
    pkg/agent/apiserver/handlers/ovsflows/handler.go

Signed-off-by: Hongliang Liu lhongliang@vmware.com

@hongliangl
Copy link
Contributor Author

/skip-all

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #3348 (111bfc4) into main (3f30d84) will decrease coverage by 5.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3348      +/-   ##
==========================================
- Coverage   60.85%   55.32%   -5.53%     
==========================================
  Files         266      374     +108     
  Lines       26520    51704   +25184     
==========================================
+ Hits        16139    28607   +12468     
- Misses       8591    20606   +12015     
- Partials     1790     2491     +701     
Flag Coverage Δ
e2e-tests 53.60% <100.00%> (?)
integration-tests 36.28% <ø> (?)
kind-e2e-tests 49.10% <100.00%> (+1.13%) ⬆️
unit-tests 41.84% <0.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/apiserver/handlers/ovsflows/handler.go 57.30% <ø> (-17.70%) ⬇️
pkg/agent/flowexporter/exporter/exporter.go 77.22% <100.00%> (-3.42%) ⬇️
pkg/agent/cniserver/pod_configuration_linux.go 26.31% <0.00%> (-40.36%) ⬇️
pkg/controller/ipam/antrea_ipam_controller.go 48.71% <0.00%> (-31.57%) ⬇️
pkg/controller/networkpolicy/endpoint_querier.go 61.46% <0.00%> (-29.97%) ⬇️
pkg/controller/egress/controller.go 61.11% <0.00%> (-27.34%) ⬇️
.../registry/networkpolicy/clustergroupmember/rest.go 64.28% <0.00%> (-23.95%) ⬇️
pkg/agent/cniserver/ipam/antrea_ipam_controller.go 55.93% <0.00%> (-23.83%) ⬇️
pkg/agent/cniserver/ipam/antrea_ipam.go 55.55% <0.00%> (-23.62%) ⬇️
pkg/agent/util/ethtool/ethtool_linux.go 46.66% <0.00%> (-23.34%) ⬇️
... and 336 more

Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use more meaningful commit message. For this one, I suggest: Fix CT mark matching without range in flow exporter

- Fix CT mark matching without range in
  pkg/agent/flowexporter/exporter/exporter.go
- Fix typo in test/e2e/connectivity_test.go
- Remove extra blank line in
  pkg/agent/apiserver/handlers/ovsflows/handler.go

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
@hongliangl hongliangl changed the title Some fixes Fix CT mark matching without range in flow exporter Feb 24, 2022
@hongliangl
Copy link
Contributor Author

Please use more meaningful commit message. For this one, I suggest: Fix CT mark matching without range in flow exporter

Thanks, updated.

@hongliangl
Copy link
Contributor Author

/skip-all

@hongliangl
Copy link
Contributor Author

/test-e2e
/test-windows-e2e

@jianjuns
Copy link
Contributor

/test-conformance

@hongliangl
Copy link
Contributor Author

/test-windows-conformance

@hongliangl
Copy link
Contributor Author

/test-networkpolicy

@jianjuns jianjuns merged commit a8bf799 into antrea-io:main Feb 26, 2022
bangqipropel pushed a commit to bangqipropel/antrea that referenced this pull request Mar 2, 2022
- Fix CT mark matching without range in
  pkg/agent/flowexporter/exporter/exporter.go
- Fix typo in test/e2e/connectivity_test.go
- Remove extra blank line in
  pkg/agent/apiserver/handlers/ovsflows/handler.go

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
@hongliangl hongliangl deleted the fix-20220223 branch April 21, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants