Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce permission of antrea service accounts #3393

Merged
merged 1 commit into from Mar 7, 2022

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Mar 3, 2022

status update/patch permission can be used to update annotations.

Signed-off-by: Quan Tian qtian@vmware.com

status update/patch permission can be used to update annotations.

Signed-off-by: Quan Tian <qtian@vmware.com>
@tnqn tnqn requested review from antoninbas and jianjuns March 3, 2022 17:35
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #3393 (1819c34) into main (fc2e855) will decrease coverage by 6.97%.
The diff coverage is 89.77%.

❗ Current head 1819c34 differs from pull request most recent head 03c8276. Consider uploading reports for the commit 03c8276 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3393      +/-   ##
==========================================
- Coverage   60.68%   53.70%   -6.98%     
==========================================
  Files         268      239      -29     
  Lines       26853    34210    +7357     
==========================================
+ Hits        16296    18373    +2077     
- Misses       8751    14066    +5315     
+ Partials     1806     1771      -35     
Flag Coverage Δ
e2e-tests 53.70% <89.77%> (?)
kind-e2e-tests ?
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/agent.go 50.12% <0.00%> (-1.04%) ⬇️
pkg/agent/nodeportlocal/k8s/annotations.go 84.44% <0.00%> (-9.11%) ⬇️
.../registry/networkpolicy/clustergroupmember/rest.go 21.42% <0.00%> (-66.81%) ⬇️
pkg/controller/networkpolicy/clustergroup.go 70.38% <60.00%> (-6.62%) ⬇️
pkg/ovs/openflow/ofctrl_nxfields.go 67.24% <76.92%> (+1.85%) ⬆️
pkg/agent/openflow/pipeline.go 66.29% <92.30%> (+0.94%) ⬆️
pkg/agent/wireguard/client_linux.go 48.40% <100.00%> (-16.78%) ⬇️
...g/controller/networkpolicy/clusternetworkpolicy.go 78.00% <100.00%> (+4.52%) ⬆️
pkg/controller/networkpolicy/crd_utils.go 78.87% <100.00%> (-8.76%) ⬇️
...ntroller/networkpolicy/networkpolicy_controller.go 73.07% <100.00%> (-8.84%) ⬇️
... and 270 more

@antoninbas
Copy link
Contributor

/test-all

@antoninbas antoninbas added action/backport Indicates a PR that requires backports. action/release-note Indicates a PR that should be included in release notes. labels Mar 4, 2022
@tnqn
Copy link
Member Author

tnqn commented Mar 7, 2022

/test-windows-all
/test-ipv6-all
/test-ipv6-only-all

@tnqn tnqn merged commit 23c4549 into antrea-io:main Mar 7, 2022
@tnqn tnqn deleted the reduce-permission branch March 7, 2022 09:16
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Mar 10, 2022
status update/patch permission can be used to update annotations.

Signed-off-by: Quan Tian <qtian@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/backport Indicates a PR that requires backports. action/release-note Indicates a PR that should be included in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants