Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kustomize from v3.8.8 to v4.4.1 to fix Cronjob patching bugs #3402

Merged
merged 1 commit into from Mar 7, 2022

Conversation

yanjunz97
Copy link
Contributor

This PR upgrades Kustomize from v3.8.8 to v4.4.1 to fix the fields-missing problem in Cronjob patching.

Signed-off-by: Yanjun Zhou zhouya@vmware.com

Signed-off-by: Yanjun Zhou <zhouya@vmware.com>
@yanjunz97
Copy link
Contributor Author

Kustomize has bugs in patching Cronjob before version 4.3.0 which leads to a fields-missing problem. I try to upgrade it to v4.4.1 and run make manifest under both antrea folder and multicluster folder. The differences between these two versions includes:

  1. v4.4.1 removes some annotations: {} in the metadata
  2. v4.4.1 adds more newlines for test in yaml file

The reason I choose v4.4.1 instead of v4.3.0

  1. With v4.3.0 I find a prefix missing problem when generating antrea-multicluster-leader-namespaced.yml. It replaces antrea-mc-controller with cotroller. But this is fixed after v4.4.0
  2. v4.4.1 mainly adds more fixes comparing to v4.4.0

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2022

Codecov Report

Merging #3402 (8ea3d02) into main (4641c65) will decrease coverage by 8.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3402      +/-   ##
==========================================
- Coverage   63.35%   54.41%   -8.94%     
==========================================
  Files         268      374     +106     
  Lines       26871    51491   +24620     
==========================================
+ Hits        17023    28018   +10995     
- Misses       8005    21063   +13058     
- Partials     1843     2410     +567     
Flag Coverage Δ
e2e-tests 53.74% <ø> (?)
integration-tests 35.83% <ø> (?)
kind-e2e-tests 47.58% <ø> (-3.60%) ⬇️
unit-tests 42.42% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/egress/store/egressgroup.go 1.72% <0.00%> (-58.00%) ⬇️
pkg/agent/cniserver/pod_configuration_linux.go 26.31% <0.00%> (-40.36%) ⬇️
pkg/controller/ipam/antrea_ipam_controller.go 48.71% <0.00%> (-31.57%) ⬇️
pkg/controller/networkpolicy/endpoint_querier.go 61.46% <0.00%> (-29.97%) ⬇️
pkg/controller/egress/controller.go 62.19% <0.00%> (-26.26%) ⬇️
pkg/controller/ipam/validate.go 57.95% <0.00%> (-24.31%) ⬇️
.../registry/networkpolicy/clustergroupmember/rest.go 64.28% <0.00%> (-23.95%) ⬇️
pkg/agent/cniserver/ipam/antrea_ipam.go 55.55% <0.00%> (-23.62%) ⬇️
pkg/agent/cniserver/ipam/antrea_ipam_controller.go 55.93% <0.00%> (-23.59%) ⬇️
pkg/agent/util/ethtool/ethtool_linux.go 46.66% <0.00%> (-23.34%) ⬇️
... and 335 more

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@luolanzone luolanzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanjunz97
Copy link
Contributor Author

/test-all

@antoninbas antoninbas merged commit 7dc81f0 into antrea-io:main Mar 7, 2022
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants