New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Kustomize from v3.8.8 to v4.4.1 to fix Cronjob patching bugs #3402
Conversation
Signed-off-by: Yanjun Zhou <zhouya@vmware.com>
|
Kustomize has bugs in patching Cronjob before version 4.3.0 which leads to a fields-missing problem. I try to upgrade it to v4.4.1 and run
The reason I choose v4.4.1 instead of v4.3.0
|
Codecov Report
@@ Coverage Diff @@
## main #3402 +/- ##
==========================================
- Coverage 63.35% 54.41% -8.94%
==========================================
Files 268 374 +106
Lines 26871 51491 +24620
==========================================
+ Hits 17023 28018 +10995
- Misses 8005 21063 +13058
- Partials 1843 2410 +567
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/test-all |
…ntrea-io#3402) Signed-off-by: Yanjun Zhou <zhouya@vmware.com>
This PR upgrades Kustomize from v3.8.8 to v4.4.1 to fix the fields-missing problem in Cronjob patching.
Signed-off-by: Yanjun Zhou zhouya@vmware.com