Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade packaged Whereabouts version to v0.5.1 #3511

Merged
merged 1 commit into from Mar 23, 2022

Conversation

antoninbas
Copy link
Contributor

Notable chnages:

  • bug fixes for race conditions when using K8s CRD backend
  • support for CNI version

Now that Whereabouts publishes the binaries as release assets, we can
remove the hack/build-whereabouts.sh script.

Fixes #3473

Signed-off-by: Antonin Bas abas@vmware.com

Notable chnages:
* bug fixes for race conditions when using K8s CRD backend
* support for CNI version

Now that Whereabouts publishes the binaries as release assets, we can
remove the hack/build-whereabouts.sh script.

Fixes antrea-io#3473

Signed-off-by: Antonin Bas <abas@vmware.com>
@antoninbas antoninbas added action/release-note Indicates a PR that should be included in release notes. area/dependency Issues or PRs related to dependency changes. area/build-release Issues or PRs related to building and releasing labels Mar 23, 2022
@antoninbas antoninbas added this to the Antrea v1.6 release milestone Mar 23, 2022
@antoninbas
Copy link
Contributor Author

Test with both antrea/base-ubi:2.15.1 and antrea/base-ubuntu:2.15.1

abas-a01:base abas$ docker run -ti antrea/base-ubuntu:2.15.1
root@208edffa4c93:/# /opt/cni/bin/whereabouts
whereabouts v0.5.1 linux/amd64
root@208edffa4c93:/# exit
abas-a01:base abas$ docker run -ti antrea/base-ubi:2.15.1
[root@cdb0441a1598 /]# /opt/cni/bin/whereabouts
whereabouts v0.5.1 linux/amd64
[root@cdb0441a1598 /]# exit

@antoninbas
Copy link
Contributor Author

@arunvelayutham FYI

Copy link
Contributor

@arunvelayutham arunvelayutham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you for taking care of this @antoninbas

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2022

Codecov Report

Merging #3511 (2104342) into main (2c7d486) will decrease coverage by 7.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3511      +/-   ##
==========================================
- Coverage   65.58%   58.24%   -7.35%     
==========================================
  Files         277      277              
  Lines       27264    27264              
==========================================
- Hits        17881    15879    -2002     
- Misses       7483     9623    +2140     
+ Partials     1900     1762     -138     
Flag Coverage Δ
kind-e2e-tests 40.41% <ø> (-15.54%) ⬇️
unit-tests 43.10% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apis/controlplane/types.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/agent/controller/networkpolicy/reject.go 0.00% <0.00%> (-84.68%) ⬇️
...g/agent/apiserver/handlers/featuregates/handler.go 0.00% <0.00%> (-82.36%) ⬇️
pkg/controller/networkpolicy/mutate.go 0.00% <0.00%> (-73.57%) ⬇️
pkg/controller/networkpolicy/store/group.go 5.00% <0.00%> (-70.00%) ⬇️
pkg/agent/controller/networkpolicy/packetin.go 0.00% <0.00%> (-68.37%) ⬇️
pkg/apis/controlplane/helper.go 33.33% <0.00%> (-66.67%) ⬇️
pkg/apis/controlplane/v1beta2/helper.go 33.33% <0.00%> (-66.67%) ⬇️
pkg/controller/networkpolicy/convert.go 0.00% <0.00%> (-64.52%) ⬇️
pkg/controller/egress/store/egressgroup.go 1.38% <0.00%> (-58.34%) ⬇️
... and 82 more

@antoninbas
Copy link
Contributor Author

/skip-all

@antoninbas antoninbas merged commit 3c88bc2 into antrea-io:main Mar 23, 2022
@antoninbas antoninbas deleted the update-whereabouts-to-0.5.1 branch March 23, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/release-note Indicates a PR that should be included in release notes. area/build-release Issues or PRs related to building and releasing area/dependency Issues or PRs related to dependency changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade whereabout to latest 0.5.1?
4 participants