Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v2/bar): add basic bar chart #1330

Merged
merged 2 commits into from Jul 24, 2020
Merged

feat(v2/bar): add basic bar chart #1330

merged 2 commits into from Jul 24, 2020

Conversation

BBSQQ
Copy link
Member

@BBSQQ BBSQQ commented Jul 23, 2020

No description provided.

@BBSQQ BBSQQ requested review from lessmost, hustcc and visiky July 23, 2020 13:18
@auto-add-label auto-add-label bot added the enhancement New feature or request label Jul 23, 2020
tests-checker[bot]
tests-checker bot suggested changes Jul 23, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@lgtm-com
Copy link

lgtm-com bot commented Jul 23, 2020

This pull request introduces 1 alert when merging 3a1406c into 8da53b8 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lessmost lessmost merged commit f435305 into v2 Jul 24, 2020
@lessmost lessmost deleted the v2-bar branch July 24, 2020 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker requested changes

@lessmost lessmost lessmost approved these changes

@hustcc hustcc Awaiting requested review from hustcc

@visiky visiky Awaiting requested review from visiky

Assignees
No one assigned
Labels
enhancement New feature or request PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BBSQQ @lessmost