Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working on render engine #72

Merged
merged 76 commits into from
Feb 19, 2020
Merged

working on render engine #72

merged 76 commits into from
Feb 19, 2020

Conversation

bubkoo
Copy link
Member

@bubkoo bubkoo commented Jan 13, 2020

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pr-triage pr-triage bot added the PR: unreviewed PR does not have any reviews. label Jan 13, 2020
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@pr-triage pr-triage bot added PR: reviewed-changes-requested PR has reviewed and got Change request event. and removed PR: unreviewed PR does not have any reviews. labels Jan 13, 2020
@github-actions github-actions bot added PR(feature) :tada: New feature pkg:x6 labels Jan 13, 2020
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jan 13, 2020

This pull request introduces 2 alerts when merging 99ca5e1 into 7109e88 - view on LGTM.com

new alerts:

  • 1 for Duplicate switch case
  • 1 for Unneeded defensive code

@pr-triage pr-triage bot added PR: unreviewed PR does not have any reviews. and removed PR: reviewed-changes-requested PR has reviewed and got Change request event. labels Jan 13, 2020
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jan 13, 2020

This pull request introduces 2 alerts when merging 58fdee6 into 7109e88 - view on LGTM.com

new alerts:

  • 1 for Duplicate switch case
  • 1 for Unneeded defensive code

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jan 14, 2020

This pull request introduces 1 alert when merging 8f1a563 into 7109e88 - view on LGTM.com

new alerts:

  • 1 for Variable not declared before use

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jan 14, 2020

This pull request introduces 1 alert when merging 8d4f89f into 7109e88 - view on LGTM.com

new alerts:

  • 1 for Variable not declared before use

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jan 14, 2020

This pull request introduces 1 alert when merging 1938118 into 7109e88 - view on LGTM.com

new alerts:

  • 1 for Variable not declared before use

@bubkoo bubkoo merged commit e8c7f7a into master Feb 19, 2020
@bubkoo bubkoo deleted the feat/joint branch February 19, 2020 09:07
@pr-triage pr-triage bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels Feb 19, 2020
@antvis antvis deleted a comment from x6-bot bot Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR(feature) :tada: New feature PR: merged PR has merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant